You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/10 22:17:10 UTC

[GitHub] [arrow] kou opened a new pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

kou opened a new pull request #9157:
URL: https://github.com/apache/arrow/pull/9157


   "-Dprotobuf_MSVC_STATIC_RUNTIME=" (empty value) is a problem on this
   case.
   
   This is caused by ARROW-9400, 0ed34c83c6b1e862c3d8aad6bc9374759b64ea55 .
   
   https://github.com/ursa-labs/crossbow/runs/1675885130#step:5:877
   
       FAILED: grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure
       cd /.../grpc_ep-prefix/src/grpc_ep-build &&
       cmake -P /.../grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure-RELEASE.cmake &&
       cmake -E touch /.../grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure
       CMake Error at /.../grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure-RELEASE.cmake:16 (message):
         Command failed: 1
   
          '/usr/bin/cmake'
          '-DCMAKE_C_COMPILER=/usr/bin/cc'
          '-DCMAKE_CXX_COMPILER=/usr/bin/c++'
          '-DCMAKE_AR=/usr/bin/ar'
          '-DCMAKE_RANLIB=/usr/bin/ranlib'
          '-DCMAKE_BUILD_TYPE=RELEASE'
          '-DCMAKE_C_FLAGS=...'
          '-DCMAKE_C_FLAGS_RELEASE=...'
          '-DCMAKE_CXX_FLAGS=...'
          '-DCMAKE_CXX_FLAGS_RELEASE=...'
          '-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY='
          '-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY='
          '-DCMAKE_PREFIX_PATH=';/.../protobuf_ep-install;;/.../cares_ep-install;;/.../absl_ep-install''
          '-DgRPC_ABSL_PROVIDER=package'
          '-DgRPC_BUILD_CSHARP_EXT=OFF'
          '-DgRPC_BUILD_GRPC_CSHARP_PLUGIN=OFF'
          '-DgRPC_BUILD_GRPC_NODE_PLUGIN=OFF'
          '-DgRPC_BUILD_GRPC_OBJECTIVE_C_PLUGIN=OFF'
          '-DgRPC_BUILD_GRPC_PHP_PLUGIN=OFF'
          '-DgRPC_BUILD_GRPC_PYTHON_PLUGIN=OFF'
          '-DgRPC_BUILD_GRPC_RUBY_PLUGIN=OFF'
          '-DgRPC_BUILD_TESTS=OFF'
          '-DgRPC_CARES_PROVIDER=package'
          '-DgRPC_GFLAGS_PROVIDER=package'
          '-DgRPC_MSVC_STATIC_RUNTIME='
          '-DgRPC_PROTOBUF_PROVIDER=package'
          '-DgRPC_PROTOBUF_PACKAGE_TYPE=CONFIG'
          '-DgRPC_RE2_PROVIDER=package'
          '-DgRPC_SSL_PROVIDER=package'
          '-DgRPC_ZLIB_PROVIDER=package'
          '-DgRPC_MSVC_STATIC_RUNTIME='
          '-DCMAKE_INSTALL_PREFIX=/.../grpc_ep-install'
          '-DCMAKE_INSTALL_LIBDIR=lib'
          '-DBUILD_SHARED_LIBS=OFF'
          '-GNinja'
          '/.../grpc_ep-prefix/src/grpc_ep'
   
         See also
   
           /.../grpc_ep-prefix/src/grpc_ep-stamp/grpc_ep-configure-*.log
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou closed pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

Posted by GitBox <gi...@apache.org>.
kou closed pull request #9157:
URL: https://github.com/apache/arrow/pull/9157


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-757553962


   @github-actions crossbow submit -g linux


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-757553791


   The changes in `dev/tasks/linux-packages/package-task.rb` aren't related to this fix.
   The changes are convenient to debug this problem in reproduced environment (RPM build environment in this case).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-758317630


   @github-actions crossbow submit centos-*-amd64


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-757554167


   Revision: b3d1418a19342afc58ae9234c4784f356300f715
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-866](https://github.com/ursa-labs/crossbow/branches/all?query=actions-866)
   
   |Task|Status|
   |----|------|
   |centos-7-aarch64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-866-travis-centos-7-aarch64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |centos-7-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-866-github-centos-7-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-866-github-centos-7-amd64)|
   |centos-8-aarch64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-866-travis-centos-8-aarch64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |centos-8-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-866-github-centos-8-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-866-github-centos-8-amd64)|
   |debian-buster-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-866-github-debian-buster-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-866-github-debian-buster-amd64)|
   |debian-buster-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-866-travis-debian-buster-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-bionic-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-866-github-ubuntu-bionic-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-866-github-ubuntu-bionic-amd64)|
   |ubuntu-bionic-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-866-travis-ubuntu-bionic-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-focal-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-866-github-ubuntu-focal-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-866-github-ubuntu-focal-amd64)|
   |ubuntu-focal-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-866-travis-ubuntu-focal-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-groovy-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-866-github-ubuntu-groovy-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-866-github-ubuntu-groovy-amd64)|
   |ubuntu-groovy-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-866-travis-ubuntu-groovy-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-xenial-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-866-github-ubuntu-xenial-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-866-github-ubuntu-xenial-amd64)|
   |ubuntu-xenial-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-866-travis-ubuntu-xenial-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-758326299


   Revision: 1806d481cad540d3f155eece06e85d8e4bb69947
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-874](https://github.com/ursa-labs/crossbow/branches/all?query=actions-874)
   
   |Task|Status|
   |----|------|
   |centos-7-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-874-github-centos-7-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-874-github-centos-7-amd64)|
   |centos-8-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-874-github-centos-8-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-874-github-centos-8-amd64)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-758181943


   @github-actions crossbow submit centos-*-amd64


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-757573590


   @github-actions crossbow submit -g linux


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#discussion_r554648227



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2460,15 +2466,9 @@ macro(build_grpc)
       -DgRPC_RE2_PROVIDER=package
       -DgRPC_SSL_PROVIDER=package
       -DgRPC_ZLIB_PROVIDER=package
-      -DgRPC_MSVC_STATIC_RUNTIME=${ARROW_USE_STATIC_CRT}
       -DCMAKE_INSTALL_PREFIX=${GRPC_PREFIX}
       -DCMAKE_INSTALL_LIBDIR=lib
       -DBUILD_SHARED_LIBS=OFF)
-  if(RE2_VENDORED)
-    list(APPEND GRPC_CMAKE_ARGS -Dre2_ROOT=${RE2_PREFIX}

Review comment:
       We can't use `<PackageName>_ROOT` with CMake 3.11 or older.
   (This is not related to MSVC.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-757553579


   https://issues.apache.org/jira/browse/ARROW-11204


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-757573754


   Revision: 218829af712ca289fa70ed4193a4922e89d21ee2
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-867](https://github.com/ursa-labs/crossbow/branches/all?query=actions-867)
   
   |Task|Status|
   |----|------|
   |centos-7-aarch64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-867-travis-centos-7-aarch64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |centos-7-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-867-github-centos-7-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-867-github-centos-7-amd64)|
   |centos-8-aarch64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-867-travis-centos-8-aarch64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |centos-8-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-867-github-centos-8-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-867-github-centos-8-amd64)|
   |debian-buster-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-867-github-debian-buster-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-867-github-debian-buster-amd64)|
   |debian-buster-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-867-travis-debian-buster-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-bionic-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-867-github-ubuntu-bionic-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-867-github-ubuntu-bionic-amd64)|
   |ubuntu-bionic-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-867-travis-ubuntu-bionic-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-focal-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-867-github-ubuntu-focal-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-867-github-ubuntu-focal-amd64)|
   |ubuntu-focal-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-867-travis-ubuntu-focal-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-groovy-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-867-github-ubuntu-groovy-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-867-github-ubuntu-groovy-amd64)|
   |ubuntu-groovy-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-867-travis-ubuntu-groovy-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |ubuntu-xenial-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-867-github-ubuntu-xenial-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-867-github-ubuntu-xenial-amd64)|
   |ubuntu-xenial-arm64|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-867-travis-ubuntu-xenial-arm64.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-758443365


   +1
   The Java JNI failure is unrelated: https://github.com/apache/arrow/pull/9157/checks?check_run_id=1685053738#step:17:1
   
   ```text
   Post job cleanup.
   /bin/tar -cz -f /home/runner/work/_temp/2ff4a229-7a60-4949-af10-5e26fe774e4c/cache.tgz -C /home/runner/work/arrow/arrow/.docker .
   Warning: read ECONNRESET
   events.js:187
         throw er; // Unhandled 'error' event
         ^
   
   Error: EBADF: bad file descriptor, read
   Emitted 'error' event on ReadStream instance at:
       at internal/fs/streams.js:167:12
       at FSReqCallback.wrapper [as oncomplete] (fs.js:470:5) {
     errno: -9,
     code: 'EBADF',
     syscall: 'read'
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9157: ARROW-11204: [C++] Fix build failures with bundled gRPC and Protobuf

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#issuecomment-758263630


   Revision: 218829af712ca289fa70ed4193a4922e89d21ee2
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-872](https://github.com/ursa-labs/crossbow/branches/all?query=actions-872)
   
   |Task|Status|
   |----|------|
   |centos-7-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-872-github-centos-7-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-872-github-centos-7-amd64)|
   |centos-8-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-872-github-centos-8-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-872-github-centos-8-amd64)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org