You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2015/05/20 11:04:39 UTC
Review Request 34462: Add logMover check in FeedReplication test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34462/
-----------------------------------------------------------
Review request for Falcon and samarth gupta.
Bugs: FALCON-1227
https://issues.apache.org/jira/browse/FALCON-1227
Repository: falcon-git
Description
-------
Add logMover check in FeedReplication test when replication fails/succeeds. Related to FALCON-973
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 3abca7a
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6fd2348
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java 4af27a2
Diff: https://reviews.apache.org/r/34462/diff/
Testing
-------
Tested
Thanks,
PRAGYA MITTAL
Re: Review Request 34462: Add logMover check in FeedReplication test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34462/
-----------------------------------------------------------
(Updated May 28, 2015, 1:29 p.m.)
Review request for Falcon and samarth gupta.
Changes
-------
Review comments addressed
Bugs: FALCON-1227
https://issues.apache.org/jira/browse/FALCON-1227
Repository: falcon-git
Description
-------
Add logMover check in FeedReplication test when replication fails/succeeds. Related to FALCON-973
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 3abca7a
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6fd2348
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java 4af27a2
Diff: https://reviews.apache.org/r/34462/diff/
Testing
-------
Tested
Thanks,
PRAGYA MITTAL
Re: Review Request 34462: Add logMover check in FeedReplication test
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34462/#review84978
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java
<https://reviews.apache.org/r/34462/#comment136430>
Can be replaced with smth like:
String part = logFlag ? "SUCCEEDED" : "FAILED";
for (Path logmoverPath : logmoverPaths) {
if (logmoverPath.toString().contains(part)) {
return true;
}
}
return false;
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
<https://reviews.apache.org/r/34462/#comment136434>
//check if instance became killed
- Paul Isaychuk
On May 20, 2015, 9:04 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34462/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 9:04 a.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Bugs: FALCON-1227
> https://issues.apache.org/jira/browse/FALCON-1227
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add logMover check in FeedReplication test when replication fails/succeeds. Related to FALCON-973
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 3abca7a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6fd2348
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java 4af27a2
>
> Diff: https://reviews.apache.org/r/34462/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 34462: Add logMover check in FeedReplication test
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34462/#review84980
-----------------------------------------------------------
minor comments, my +1 after they are addressed
- Paul Isaychuk
On May 20, 2015, 9:04 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34462/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 9:04 a.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Bugs: FALCON-1227
> https://issues.apache.org/jira/browse/FALCON-1227
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add logMover check in FeedReplication test when replication fails/succeeds. Related to FALCON-973
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 3abca7a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6fd2348
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java 4af27a2
>
> Diff: https://reviews.apache.org/r/34462/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>