[jira] Commented: (SOLR-521) Allow StopFilterFactory to use StopFilter setEnablePositionIncrementsDefault function

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604658#action_12604658 ] 

Hoss Man commented on SOLR-521:
-------------------------------

I was going to change the default, and i'd even already written up the CHANGES.txt verbage to include in, when i noticed that it caused 2 tests to fail: on for DisMax and one in ConvertedLegacyTest.

This wasn't a huge surprise, i figured the test were just expecting "broken" behavior, but when i looked at exact failures they were by no means obvious failures.  In both cases doing "the right thing" had some subtle impacts on the matching/scoring of docs that made me realize changing the default is probably not in the best interests of existing users (if it caused problems like this in our simple unit tests, it could have some pretty serious impacts on real world cases)

FWIW, here's the verbage i *was* going to add...

{quote}

A new "enablePositionIncrements" option has been added to the
StopFilterFactory.  The default value is "true", indicating that a
"gap" should be left when a stop word is removed, which will affect
how much slop is required in order for Phrase Queries to match.  Users
who wish to preserve previous behavior should add
'enablePositionIncrements="false"' to usages of StopFilterFactory in
their schema.xml.  Other users should consider reindexing to ensure
consistency in behavior for all documents. 
{quote}

> Allow StopFilterFactory to use StopFilter setEnablePositionIncrementsDefault function
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-521
>                 URL: https://issues.apache.org/jira/browse/SOLR-521
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Walter Ferrara
>            Assignee: Hoss Man
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: stopfilter.patch, stopfilter.patch
>
>
> Lucene StopFilter has a function, setEnablePositionIncrementsDefault,  that when set, "when a token is stopped (omitted), the position increment of the following token is incremented". Solr however have no setting in schema.xml to activate this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.