[jira] Commented: (JSPWIKI-613) InsertPage plugin and the feature of section editing do not fit together

["Janne Jalkanen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JSPWIKI-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781325#action_12781325 ] 

Janne Jalkanen commented on JSPWIKI-613:
----------------------------------------

Thanks for the report and welcome :-)

You're right, the section editing should point at the included page and not the host page.  However, the way that section editing is currently done is that it's completely done on the client side.  The problem is that the page is included on the server side...

Dirk, any ideas on how this should be handled? The only thing I can think of is that the heading anchor tags do reveal which page was included, but that may not be reliable (the anchor generation method loses information).  One possibility would be to disable the section edit links for included pages - this should be possible to deduce from the anchor names.

> InsertPage plugin and the feature of section editing do not fit together
> ------------------------------------------------------------------------
>
>                 Key: JSPWIKI-613
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-613
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8.3
>         Environment: Current versions of Windows XP and Firefox running in a virtual machine of VMWare Fusion on a Mac Server
>            Reporter: Mario Lotz
>            Priority: Minor
>
> I often used the *InsertPage plugin* to separate structure  of my presentation from the content. Normaly I include pages into tabbed sections to give my users a single point of entry to the same kind of information.
> If the *section editing feature* is enabled the rendered *edit links* are pointing to the {color:red}_including_{color} page instead of the {color:red}_included_{color} ones.
> I assume, that the links are added to the page after the includes are done. To fix the wrong links, the edit links have to be inserted for each included page independent of the parent and with a separate heading counter.
> This is my first bug report for your great JSPWiki and I hope to give you enough information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.