You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/10/29 01:02:41 UTC

Review Request 39743: AMBARI-13595. Stop-and-Start Upgrade: Handle Storm in all upgrade paths

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39743/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-13595
    https://issues.apache.org/jira/browse/AMBARI-13595


Repository: ambari


Description
-------

Allow Storm service to be upgraded/downgraded during Express Upgrade in the following paths,
HDP 2.1->2.3  (this path requires removing STORM_REST_API component first)
HDP 2.2->2.2.*
HDP 2.2->2.3
HDP 2.3->2.3.*


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java fef4f7e 
  ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 536a5ad 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py e1cb5ba 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6f8d5b0 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py f9d64f4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py 9c36a78 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py 5d90f5b 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py 5d01dc6 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py 335aeeb 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py f3074f1 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py abe144f 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 5e33187 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 623cc38 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 69112d4 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml c283391 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml d3e209e 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cb998b3 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ea2c63f 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 7eb3f50 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 39c7ee3 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py e1506d8 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 127e63d 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py ef1c91e 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py cd06e5b 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 78e8202 

Diff: https://reviews.apache.org/r/39743/diff/


Testing
-------

Testing during Express Upgrade.
Python unit tests passed.

----------------------------------------------------------------------
Total run:825
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 39743: AMBARI-13595. Stop-and-Start Upgrade: Handle Storm in all upgrade paths

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39743/#review104374
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java (line 71)
<https://reviews.apache.org/r/39743/#comment162630>

    This component is deleted starting in HDP 2.2



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py (line 55)
<https://reviews.apache.org/r/39743/#comment162631>

    STORM_REST_API is actually never part of an upgrade since only available in HDP 2.1 and earlier.


- Alejandro Fernandez


On Oct. 29, 2015, 12:02 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39743/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 12:02 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-13595
>     https://issues.apache.org/jira/browse/AMBARI-13595
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow Storm service to be upgraded/downgraded during Express Upgrade in the following paths,
> HDP 2.1->2.3  (this path requires removing STORM_REST_API component first)
> HDP 2.2->2.2.*
> HDP 2.2->2.3
> HDP 2.3->2.3.*
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java fef4f7e 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 536a5ad 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py e1cb5ba 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6f8d5b0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py f9d64f4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py 9c36a78 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py 5d90f5b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py 5d01dc6 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py 335aeeb 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py f3074f1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py abe144f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 5e33187 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 623cc38 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 69112d4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml c283391 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml d3e209e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cb998b3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml ea2c63f 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 7eb3f50 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 39c7ee3 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py e1506d8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 127e63d 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py ef1c91e 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py cd06e5b 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 78e8202 
> 
> Diff: https://reviews.apache.org/r/39743/diff/
> 
> 
> Testing
> -------
> 
> Testing during Express Upgrade.
> Python unit tests passed.
> 
> ----------------------------------------------------------------------
> Total run:825
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>