[GitHub] [airflow] mik-laj commented on a change in pull request #17382: Add new LocalFilesystemToS3Operator under Amazon provider (#17168)

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #17382:
URL: https://github.com/apache/airflow/pull/17382#discussion_r688843188



##########
File path: airflow/providers/amazon/aws/example_dags/example_local_to_s3.py
##########
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+import os
+
+from airflow import models
+from airflow.providers.amazon.aws.transfers.local_to_s3 import LocalFilesystemToS3Operator
+from airflow.utils.dates import datetime
+
+S3_BUCKET = os.environ.get("S3_BUCKET", "test-bucket")

Review comment:
       Let's do this as a separate contribution because it makes sense to standardize all the variables and write it down as a generally accepted rule to make it more permanent. Now, if we change the variable name in one place, we will fix the problem only here, but in a moment subsequent contributions may not see this convention and introduce a different naming convention.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org