You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/05/02 03:40:50 UTC

Review Request: Added os/linux.hpp os/osx.hpp os/process.hpp as a pre-requisite for implementing generalized process utilities.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10895/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

Most of this is just moving this into place for implementing os namespace process utilities.


Diffs
-----

  third_party/libprocess/third_party/stout/Makefile.am 4af647e717d41380b4c457aa51884b5b4f186da8 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp ef9fb18173a592a288703b4a123da5c92a80a3e0 
  third_party/libprocess/third_party/stout/include/stout/os.hpp c71ae9ed32af2a14dc7b9b34521cb5ea6025235c 
  third_party/libprocess/third_party/stout/include/stout/os/linux.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os/ls.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os/osx.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/os/process.hpp PRE-CREATION 
  third_party/libprocess/third_party/stout/include/stout/proc.hpp b59735fbe993839aae3cb9ca7871517798c4cd46 
  third_party/libprocess/third_party/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f 
  third_party/libprocess/third_party/stout/tests/proc_tests.cpp 2305ef53b700d5092802eab6f54a2893f5622e02 

Diff: https://reviews.apache.org/r/10895/diff/


Testing
-------

make check on OSX and Linux.


Thanks,

Ben Mahler

Re: Review Request: Added os/linux.hpp os/osx.hpp os/process.hpp as a pre-requisite for implementing generalized process utilities.

Posted by Ben Mahler <be...@gmail.com>.

> On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote:
> >

Will be discarding and sending out a separate chain for this due to the restructuring.


> On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote:
> > third_party/libprocess/third_party/stout/tests/os_tests.cpp, line 300
> > <https://reviews.apache.org/r/10895/diff/1/?file=286970#file286970line300>
> >
> >     Have we ever done a 'wait' for children we kill? Clearly we can't wait for the grandchildren, and this probably isn't that big a deal, just thought I'd suggest the thought exercise.

Hm.. good point, are you suggesting this and other tests wait() to reap the child?

Added a TODO.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10895/#review20294
-----------------------------------------------------------


On May 2, 2013, 1:40 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10895/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 1:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Most of this is just moving this into place for implementing os namespace process utilities.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/Makefile.am 4af647e717d41380b4c457aa51884b5b4f186da8 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp ef9fb18173a592a288703b4a123da5c92a80a3e0 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp c71ae9ed32af2a14dc7b9b34521cb5ea6025235c 
>   third_party/libprocess/third_party/stout/include/stout/os/linux.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os/ls.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os/osx.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os/process.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/proc.hpp b59735fbe993839aae3cb9ca7871517798c4cd46 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f 
>   third_party/libprocess/third_party/stout/tests/proc_tests.cpp 2305ef53b700d5092802eab6f54a2893f5622e02 
> 
> Diff: https://reviews.apache.org/r/10895/diff/
> 
> 
> Testing
> -------
> 
> make check on OSX and Linux.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Added os/linux.hpp os/osx.hpp os/process.hpp as a pre-requisite for implementing generalized process utilities.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10895/#review20294
-----------------------------------------------------------

Ship it!



third_party/libprocess/third_party/stout/include/stout/os/linux.hpp
<https://reviews.apache.org/r/10895/#comment41828>

    s/linux/Linux/



third_party/libprocess/third_party/stout/tests/os_tests.cpp
<https://reviews.apache.org/r/10895/#comment41829>

    Have we ever done a 'wait' for children we kill? Clearly we can't wait for the grandchildren, and this probably isn't that big a deal, just thought I'd suggest the thought exercise. 


- Benjamin Hindman


On May 2, 2013, 1:40 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10895/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 1:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Most of this is just moving this into place for implementing os namespace process utilities.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/Makefile.am 4af647e717d41380b4c457aa51884b5b4f186da8 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp ef9fb18173a592a288703b4a123da5c92a80a3e0 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp c71ae9ed32af2a14dc7b9b34521cb5ea6025235c 
>   third_party/libprocess/third_party/stout/include/stout/os/linux.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os/ls.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os/osx.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/os/process.hpp PRE-CREATION 
>   third_party/libprocess/third_party/stout/include/stout/proc.hpp b59735fbe993839aae3cb9ca7871517798c4cd46 
>   third_party/libprocess/third_party/stout/tests/os_tests.cpp 047778d05ebbbefd85e4a163dbb6ab8445edfb7f 
>   third_party/libprocess/third_party/stout/tests/proc_tests.cpp 2305ef53b700d5092802eab6f54a2893f5622e02 
> 
> Diff: https://reviews.apache.org/r/10895/diff/
> 
> 
> Testing
> -------
> 
> make check on OSX and Linux.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>