You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/08/16 20:20:11 UTC
[PR] Gate the public API on binary compatibility [maven-doxia-sitetools]
slachiewicz opened a new pull request, #677:
URL: https://github.com/apache/maven-doxia-sitetools/pull/677
Sitetools has no API compatibility check at all. The `clirr-maven-plugin` configuration is commented out in both `pluginManagement` and `build`, carries a "TODO need to upgrade" note, and compares against 1.9 — so nothing has been guarding the public API across the whole 2.x line, while doxia has enforced japicmp against a 2.0.0 baseline for some time.
This applies the same configuration and drops the dead clirr blocks.
Gated are the four modules that were already published in 2.0.0. `doxia-site-scm-context` is deliberately left out: it first shipped in 2.1.0, so there is no 2.0.0 artifact to compare against and `ignoreMissingOldVersion` is `false`.
The current tree turns out to be binary compatible with 2.0.0 already, so this records the existing state rather than changing it — no exclusions were needed.
Verified two ways, because a compatibility gate that never fails is worse than none: `mvn clean verify` passes across all six modules, and deleting `SiteRenderingContext#addSiteDirectory(File)` makes the build fail with `SiteRenderingContext.addSiteDirectory(java.io.File):METHOD_REMOVED`.
*This change was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Gate the public API on binary compatibility [maven-doxia-sitetools]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #677: Gate the public API on binary compatibility
URL: https://github.com/apache/maven-doxia-sitetools/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Gate the public API on binary compatibility [maven-doxia-sitetools]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #677:
URL: https://github.com/apache/maven-doxia-sitetools/pull/677#issuecomment-5315491924
That was true for 1.x to 2.x change. Idea behind that was about to not break 2.x line but yes for sure this may be optional check. As Social is stable and no planned bug changes are planned it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org