You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "abeizn (via GitHub)" <gi...@apache.org> on 2023/09/19 07:31:41 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #6110: fix: bamboo search-remote-scopes api
abeizn opened a new pull request, #6110:
URL: https://github.com/apache/incubator-devlake/pull/6110
### Summary
fix: bamboo search-remote-scopes api
### Does this close any open issues?
related to #5640
### Screenshots

### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn merged pull request #6110: fix: bamboo search-remote-scopes api
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #6110:
URL: https://github.com/apache/incubator-devlake/pull/6110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] d4x1 commented on a diff in pull request #6110: fix: bamboo search-remote-scopes api
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on code in PR #6110:
URL: https://github.com/apache/incubator-devlake/pull/6110#discussion_r1329732180
##########
backend/plugins/bamboo/models/plan.go:
##########
@@ -120,9 +101,9 @@ func (p ApiBambooPlan) ConvertApiScope() plugin.ToolLayerScope {
}
type ApiSearchResult struct {
- Id string `json:"id"`
- EntityType string `json:"entityType"`
- Entity ApiBambooPlan `json:"entity"`
+ Id string `json:"id"`
+ Type string `json:"type"`
+ SearchEntity ApiBambooPlan `json:"searchEntity"`
Review Comment:
HTTP GET `/rest/api/latest/search/plans.json` will return
```json
{
"size": 19,
"searchResults": [
{
"id": "XMTES-XMP3",
"type": "chain",
"searchEntity": {
"id": "XMTES-XMP3",
"key": "XMTES-XMP3",
"projectName": "xmTest",
"planName": "xmp3",
"branchName": "main",
"description": "",
"type": "chain"
}
}
],
"start-index": 0,
"max-result": 19
}
```
and it's not compatiable with `ApiBambooPlan`, I think it should be updated with another struct like `SearchedApiBambooPlan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org