You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mario Ivankovits (JIRA)" <my...@incubator.apache.org> on 2005/07/07 11:09:15 UTC
[jira] Created: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
tree2 image-path encoding and fix for missing ids on images
-----------------------------------------------------------
Key: MYFACES-308
URL: http://issues.apache.org/jira/browse/MYFACES-308
Project: MyFaces
Type: Bug
Versions: 1.0.9 beta
Reporter: Mario Ivankovits
Attachments: tree2_share.diff, tree2_tomahawk.diff
When using client-side node toggling I experienced two problems:
1) The context is missing for the expanded/collapsed image url
2) no _id is rendered to toggle the images as myFaces decide it is not necessary
The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "Mario Ivankovits (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=all ]
Mario Ivankovits updated MYFACES-308:
-------------------------------------
Attachment: tree2_tomahawk.diff
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: 1.0.9 beta
> Reporter: Mario Ivankovits
> Attachments: tree2_share.diff, tree2_tomahawk.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "Mathias Werlitz (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=comments#action_12315301 ]
Mathias Werlitz commented on MYFACES-308:
-----------------------------------------
I can confirm this error.
I also created a patch that make only minimal changes to the renderer and the javascript. (tree2patch.diff)
Now there is no need any more for an ID of the toggle image.
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: 1.0.9 beta
> Reporter: Mario Ivankovits
> Attachments: tree2_share.diff, tree2_tomahawk.diff, tree2_tomahawk.diff, tree2patch.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "Mathias Werlitz (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=comments#action_12315306 ]
Mathias Werlitz commented on MYFACES-308:
-----------------------------------------
Sorry my patch fixed only half of the story.
Please ignore it.
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: 1.0.9 beta
> Reporter: Mario Ivankovits
> Attachments: tree2_share.diff, tree2_tomahawk.diff, tree2_tomahawk.diff, tree2patch.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=all ]
sean schofield updated MYFACES-308:
-----------------------------------
Version: Nightly Build
(was: 1.0.9 beta)
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: Nightly Build
> Reporter: Mario Ivankovits
> Fix For: Nightly Build
> Attachments: tree2_share.diff, tree2_tomahawk.diff, tree2_tomahawk.diff, tree2patch.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "Mathias Werlitz (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=all ]
Mathias Werlitz updated MYFACES-308:
------------------------------------
Attachment: tree2patch.diff
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: 1.0.9 beta
> Reporter: Mario Ivankovits
> Attachments: tree2_share.diff, tree2_tomahawk.diff, tree2_tomahawk.diff, tree2patch.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "Mario Ivankovits (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=all ]
Mario Ivankovits updated MYFACES-308:
-------------------------------------
Attachment: tree2_share.diff
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: 1.0.9 beta
> Reporter: Mario Ivankovits
> Attachments: tree2_share.diff, tree2_tomahawk.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "Mario Ivankovits (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=all ]
Mario Ivankovits updated MYFACES-308:
-------------------------------------
Attachment: tree2_tomahawk.diff
This attachment also changes the time when the node states will be regenerated from the cookie.
Now the tree will reflect the current node states even if the user press "reload" or leave/reenter the page.
Thats great!!!
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: 1.0.9 beta
> Reporter: Mario Ivankovits
> Attachments: tree2_share.diff, tree2_tomahawk.diff, tree2_tomahawk.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=all ]
sean schofield closed MYFACES-308:
----------------------------------
Fix Version: Nightly Build
Resolution: Fixed
This was introduced *after* 1.0.9 release. A change to HtmlRendererUtils made it so that the id attribute was only rendered if it was not autogenerated by JSF. Since the expand/collapse and nav images were dynamically created JSF components, they had ids that were not considered necessary to output to the HTML anymore.) Problem was fixed by adding a special prefix before the auto-generated id so that the id was always rendered. Thanks to Bruno for the suggested fix.
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: Nightly Build
> Reporter: Mario Ivankovits
> Fix For: Nightly Build
> Attachments: tree2_share.diff, tree2_tomahawk.diff, tree2_tomahawk.diff, tree2patch.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-308) tree2 image-path encoding and fix for missing ids on images
Posted by "Mario Ivankovits (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-308?page=comments#action_12315279 ]
Mario Ivankovits commented on MYFACES-308:
------------------------------------------
I have seen my latest tree2_tomahawk patch introduces a problem.
I tried to always use the cookie to restore the tree expand/collaps state, but now, the users isnt able to override them.
So please ignore the version "07/Jul/05 01:01 PM" and only apply the version from "07/Jul/05 11:03 AM"
> tree2 image-path encoding and fix for missing ids on images
> -----------------------------------------------------------
>
> Key: MYFACES-308
> URL: http://issues.apache.org/jira/browse/MYFACES-308
> Project: MyFaces
> Type: Bug
> Versions: 1.0.9 beta
> Reporter: Mario Ivankovits
> Attachments: tree2_share.diff, tree2_tomahawk.diff, tree2_tomahawk.diff
>
> When using client-side node toggling I experienced two problems:
> 1) The context is missing for the expanded/collapsed image url
> 2) no _id is rendered to toggle the images as myFaces decide it is not necessary
> The attached patches fix these issues
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira