You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/29 16:49:35 UTC

[GitHub] [spark] squito commented on a change in pull request #24497: [SPARK-27630][CORE]Stage retry causes totalRunningTasks calculation to be negative

squito commented on a change in pull request #24497: [SPARK-27630][CORE]Stage retry causes totalRunningTasks calculation to be negative
URL: https://github.com/apache/spark/pull/24497#discussion_r288663030
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
 ##########
 @@ -272,17 +272,41 @@ class ExecutorAllocationManagerSuite
   test("ignore task end events from completed stages") {
 
 Review comment:
   the name of this test is needs to be updated.  Maybe "properly handle task end events from completed stages"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org