[GitHub] [spark] rwpenney commented on a change in pull request #29938: {SPARK-33061][SQL] Expose inverse hyperbolic trig functions through sql.functions API

[GitBox <gi...@apache.org>]

rwpenney commented on a change in pull request #29938:
URL: https://github.com/apache/spark/pull/29938#discussion_r499167700



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -1427,6 +1427,20 @@ object functions {
    */
   def acos(columnName: String): Column = acos(Column(columnName))
 
+  /**
+   * @return inverse hyperbolic cosine of `e`
+   *
+   * @group math_funcs
+   */

Review comment:
       I wasn't sure whether this is something I should put in during the pull-request, or whether it gets added at a later stage.
   
   Shall I presume that this is destined for Spark-3.1, or maybe 3.0.2?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org