You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/02/01 02:53:02 UTC

[GitHub] [dubbo-go] lin-jianjun opened a new pull request #1031: Update dubbo_invoker.go

lin-jianjun opened a new pull request #1031:
URL: https://github.com/apache/dubbo-go/pull/1031


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request. 
   -->
   
   **What this PR does**:
   修订远程调用次数读未使用原子操作
   **Which issue(s) this PR fixes**:
   
   Fixes #1025
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   
   ```release-note
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] Patrick0308 closed pull request #1031: Update dubbo_invoker.go

Posted by GitBox <gi...@apache.org>.
Patrick0308 closed pull request #1031:
URL: https://github.com/apache/dubbo-go/pull/1031


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] Patrick0308 commented on pull request #1031: Update dubbo_invoker.go

Posted by GitBox <gi...@apache.org>.
Patrick0308 commented on pull request #1031:
URL: https://github.com/apache/dubbo-go/pull/1031#issuecomment-771311532


   It's fixed in #1034 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks commented on pull request #1031: Update dubbo_invoker.go

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1031:
URL: https://github.com/apache/dubbo-go/pull/1031#issuecomment-770713563


   pls change the target branch to 1.5


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] Patrick0308 closed pull request #1031: Update dubbo_invoker.go

Posted by GitBox <gi...@apache.org>.
Patrick0308 closed pull request #1031:
URL: https://github.com/apache/dubbo-go/pull/1031


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] codecov-io commented on pull request #1031: Update dubbo_invoker.go

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1031:
URL: https://github.com/apache/dubbo-go/pull/1031#issuecomment-770531902


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1031?src=pr&el=h1) Report
   > Merging [#1031](https://codecov.io/gh/apache/dubbo-go/pull/1031?src=pr&el=desc) (5e6e4a4) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/5c760406a9eb9ce5b52574b63b3ceb320a31d863?el=desc) (5c76040) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1031/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1031?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop    #1031      +/-   ##
   ===========================================
   - Coverage    59.51%   59.49%   -0.02%     
   ===========================================
     Files          261      261              
     Lines        12960    12960              
   ===========================================
   - Hits          7713     7711       -2     
   - Misses        4272     4274       +2     
     Partials       975      975              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1031?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1031/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `75.00% <0.00%> (ø)` | |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1031/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1031?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1031?src=pr&el=footer). Last update [5c76040...5e6e4a4](https://codecov.io/gh/apache/dubbo-go/pull/1031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] Patrick0308 commented on pull request #1031: Update dubbo_invoker.go

Posted by GitBox <gi...@apache.org>.
Patrick0308 commented on pull request #1031:
URL: https://github.com/apache/dubbo-go/pull/1031#issuecomment-771311532


   It's fixed in #1034 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org