[jira] [Created] (FELIX-3911) Remove duplicate field injections when composition manager is used

["Tuomas Kiviaho (JIRA)" <ji...@apache.org>]

Tuomas Kiviaho created FELIX-3911:
-------------------------------------

             Summary: Remove duplicate field injections when composition manager is used
                 Key: FELIX-3911
                 URL: https://issues.apache.org/jira/browse/FELIX-3911
             Project: Felix
          Issue Type: Improvement
            Reporter: Tuomas Kiviaho
            Priority: Minor


ComponentImpl.configureImplementation injects fields multiple times when external composition manager is used. Normally the injection would not take place because service instance wouldn't have yet been created. A similar check that prohibits multiple invokeAdded on same serviceReference would solve this problem as well.

The easiest (but not backward compatible) manner I believe would be to move the injection logic to Dependency  in the spirit of invokeAdded where the serviceReference is already tracked. initService configureImplementation calls (that handle BundleContext, ServiceRegistration, Component and DependencyManager) would need to be dealt separately, but there might be room in the DependencyBase this method and ServiceDependencyImpl could just override the method with serviceReference check.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira