You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/27 01:18:30 UTC

[GitHub] [thrift] penenin commented on a change in pull request #2121: THRIFT-5185: Add support for using WebSockets as a server transport.

penenin commented on a change in pull request #2121:
URL: https://github.com/apache/thrift/pull/2121#discussion_r415449352



##########
File path: lib/cpp/src/thrift/endian.h
##########
@@ -0,0 +1,124 @@
+//

Review comment:
       Since I didn't author the file, but it states that it is in the public domain, or can be licensed under Apache 2.0, should I put the standard Apache license header in addition to the existing text or are you asking me to replace the existing text?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org