[GitHub] [spark] ScrapCodes commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

[GitBox <gi...@apache.org>]

ScrapCodes commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#discussion_r394898775
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
 ##########
 @@ -61,15 +61,15 @@ class KubernetesSuite extends SparkFunSuite
   protected var appLocator: String = _
 
   // Default memory limit is 1024M + 384M (minimum overhead constant)
-  private val baseMemory = s"${1024 + 384}Mi"
 
 Review comment:
   To be precise, in 4.7.1 Quantity constructor tries to parse the amount into format and the amount. [link](https://github.com/fabric8io/kubernetes-client/blob/v4.7.1/kubernetes-model/kubernetes-model/src/main/java/io/fabric8/kubernetes/api/model/Quantity.java#L69)
   And in 4.6.4, It does not. [link](https://github.com/fabric8io/kubernetes-client/blob/v4.6.4/kubernetes-model/kubernetes-model/src/main/java/io/fabric8/kubernetes/api/model/Quantity.java#L65)
   More details here : https://github.com/fabric8io/kubernetes-client/commit/c370d2628aa5da6b7217486373e16a35d7013df2 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org