You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "caofangkun (JIRA)" <ji...@apache.org> on 2013/12/23 02:53:51 UTC

[jira] [Updated] (STORM-183) Supervisor/worker shutdown hook should be called in distributed mode.

     [ https://issues.apache.org/jira/browse/STORM-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

caofangkun updated STORM-183:
-----------------------------

    Attachment: STORM-183-1.patch

After the patch:
kill -15 supervisor_pid 
tail -20f $STORM_HOME/logs/supervisor.log 
2013-12-20 10:34:47 b.s.d.supervisor [INFO] Shutting down supervisor ae96c39c-5e62-4e88-824d-3e5b05ac31bf
2013-12-20 10:34:47 b.s.event [INFO] Event manager interrupted
2013-12-20 10:34:47 b.s.event [INFO] Event manager interrupted
2013-12-20 10:34:47 o.a.z.ZooKeeper [INFO] Session: 0x1430dbb25c00027 closed
2013-12-20 10:34:47 o.a.z.ClientCnxn [INFO] EventThread shut down


kill -9 worker_pid 
tail -100f $STORM_HOME/logs/worker-6101.log 
2013-12-20 10:35:01 b.s.d.worker [INFO] Shutting down receive thread
2013-12-20 10:35:01 b.s.m.loader [INFO] Shutting down receiving-thread: [WordCountTopology-1-1387364272, 39931]
2013-12-20 10:35:01 b.s.m.loader [INFO] Receiving-thread:[WordCountTopology-1-1387364272, 39931] received shutdown notice
2013-12-20 10:35:01 b.s.m.loader [INFO] Waiting for receiving-thread:[WordCountTopology-1-1387364272, 39931] to die
2013-12-20 10:35:01 b.s.m.loader [INFO] Shutdown receiving-thread: [WordCountTopology-1-1387364272, 39931]
2013-12-20 10:35:01 b.s.d.worker [INFO] Shut down receive thread
2013-12-20 10:35:01 b.s.d.worker [INFO] Terminating messaging context
2013-12-20 10:35:01 b.s.d.worker [INFO] Shutting down executors
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor __acker:[3 3]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor __acker:[3 3]
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor count:[7 7]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor count:[7 7]
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor count:[11 11]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor count:[11 11]
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor count:[15 15]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor count:[15 15]
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor split:[19 19]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor split:[19 19]
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor split:[23 23]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor split:[23 23]
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor spout:[27 27]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor spout:[27 27]
2013-12-20 10:35:01 b.s.d.executor [INFO] Shutting down executor __system:[-1 -1]
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.executor [INFO] Shut down executor __system:[-1 -1]
2013-12-20 10:35:01 b.s.d.worker [INFO] Shut down executors
2013-12-20 10:35:01 b.s.d.worker [INFO] Shutting down transfer thread
2013-12-20 10:35:01 b.s.util [INFO] Async loop interrupted!
2013-12-20 10:35:01 b.s.d.worker [INFO] Shut down transfer thread
2013-12-20 10:35:01 b.s.d.worker [INFO] Shutting down default resources
2013-12-20 10:35:01 b.s.d.worker [INFO] Shut down default resources
2013-12-20 10:35:01 b.s.d.worker [INFO] Disconnecting from storm cluster state context
2013-12-20 10:35:01 o.a.z.ClientCnxn [INFO] EventThread shut down
2013-12-20 10:35:01 o.a.z.ZooKeeper [INFO] Session: 0x1430dbb25c00031 closed
2013-12-20 10:35:01 b.s.d.worker [INFO] Shut down worker WordCountTopology-1-1387364272 ae96c39c-5e62-4e88-824d-3e5b05ac31bf 39931

> Supervisor/worker shutdown hook should be called in distributed mode.
> ---------------------------------------------------------------------
>
>                 Key: STORM-183
>                 URL: https://issues.apache.org/jira/browse/STORM-183
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: caofangkun
>            Priority: Minor
>         Attachments: STORM-183-1.patch
>
>
> if the process is killed forcefully from the OS or if it's crashing due to resource issues (e.g., out of memory), shutdown hooks won't be invoked.
> -TERM (15) 
> The process is requested to stop running; it should try to exit cleanly 
> -KILL (9) 
> The process will be killed by the kernel; this signal cannot be ignored.
> So should we better use 'kill -15' ?
> See:
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/util.clj#L392
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L175
> will never be called for supervisor:
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L396
> will never be called for worker:
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/worker.clj#L421
> We'd better add something like :
> (.addShutdownHook (Runtime/getRuntime) (Thread. (fn [] (.shutdown mk-sv))))))  ?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)