You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/26 11:17:48 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5018:
Support arithmetic operators like '+', '-', '*', '/'
fx19880617 opened a new pull request #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018
To support query like:
```
select rsvp_count, rsvp_count *5 from meetupRsvp limit 10
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request
#5018: Support arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r371267505
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##########
@@ -49,6 +50,10 @@ private TransformFunctionFactory() {
put(SubtractionTransformFunction.FUNCTION_NAME.toLowerCase(), SubtractionTransformFunction.class);
put(MultiplicationTransformFunction.FUNCTION_NAME.toLowerCase(), MultiplicationTransformFunction.class);
put(DivisionTransformFunction.FUNCTION_NAME.toLowerCase(), DivisionTransformFunction.class);
+ put(SqlKind.PLUS.name().toLowerCase(), AdditionTransformFunction.class);
Review comment:
I cannot refer `AdditionTransformFunction.FUNCTION_NAME` in `CalciteSqlParser`, as `CalciteSqlParser` is in `pinot-common` module, `AdditionTransformFunction` is in `pinot-core` module.
Another option here is that I can create a `PlusTransformFunction` extends `AdditionTransformFunction`, by just overriding the function name to `plus`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request
#5018: Support arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r371267505
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##########
@@ -49,6 +50,10 @@ private TransformFunctionFactory() {
put(SubtractionTransformFunction.FUNCTION_NAME.toLowerCase(), SubtractionTransformFunction.class);
put(MultiplicationTransformFunction.FUNCTION_NAME.toLowerCase(), MultiplicationTransformFunction.class);
put(DivisionTransformFunction.FUNCTION_NAME.toLowerCase(), DivisionTransformFunction.class);
+ put(SqlKind.PLUS.name().toLowerCase(), AdditionTransformFunction.class);
Review comment:
I cannot refer `AdditionTransformFunction` in `pinot-core` from calcite parser.
Another option here is that I can create a `PlusTransformFunction` extends `AdditionTransformFunction`, by just overriding the function name to `plus`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request
#5018: Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r372043202
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -176,6 +176,8 @@ public void testHardcodedSqlQueries()
testSqlQuery(query, Collections.singletonList(query));
query = "SELECT DaysSinceEpoch, COUNT(*), MAX(ArrTime), MIN(ArrTime) FROM mytable GROUP BY DaysSinceEpoch";
testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
Review comment:
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5018:
Support arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/132009c311eb72908fe1d25a7218b1b737bda9ef?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `84.31%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
==========================================
+ Coverage 35.92% 36.07% +0.15%
==========================================
Files 1179 1180 +1
Lines 62854 62899 +45
Branches 9231 9233 +2
==========================================
+ Hits 22580 22692 +112
+ Misses 38308 38222 -86
- Partials 1966 1985 +19
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `28.9% <ø> (+0.74%)` | :arrow_up: |
| [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | :arrow_down: |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `66.66% <100%> (+2.38%)` | :arrow_up: |
| [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `85.71% <85.71%> (ø)` | |
| [...e/pinot/core/io/writer/impl/MmapMemoryManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NbWFwTWVtb3J5TWFuYWdlci5qYXZh) | `0% <0%> (-72.31%)` | :arrow_down: |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | :arrow_down: |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `41.93% <0%> (-9.68%)` | :arrow_down: |
| [.../core/io/reader/impl/v1/SortedIndexReaderImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXIvaW1wbC92MS9Tb3J0ZWRJbmRleFJlYWRlckltcGwuamF2YQ==) | `83.01% <0%> (-9.44%)` | :arrow_down: |
| [...ot/core/data/readers/PinotSegmentColumnReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUGlub3RTZWdtZW50Q29sdW1uUmVhZGVyLmphdmE=) | `29.5% <0%> (-6.56%)` | :arrow_down: |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `54.87% <0%> (-6.1%)` | :arrow_down: |
| ... and [42 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [132009c...58f5b26](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5018: Support
arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on issue #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-579012466
> How about adding ModuloTransformFunction so that we completely cover SQL arithmetic operators: https://www.w3schools.com/sql/sql_operators.asp
> Could be in this PR or as a followup. WDYT?
Added support for modulo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5018: Support
arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/132009c311eb72908fe1d25a7218b1b737bda9ef?src=pr&el=desc) will **increase** coverage by `21.14%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
=============================================
+ Coverage 35.92% 57.06% +21.14%
- Complexity 0 12 +12
=============================================
Files 1179 1179
Lines 62854 62857 +3
Branches 9231 9231
=============================================
+ Hits 22580 35870 +13290
+ Misses 38308 24355 -13953
- Partials 1966 2632 +666
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `91.32% <ø> (+63.16%)` | `0 <0> (ø)` | :arrow_down: |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `71.66% <100%> (+7.38%)` | `0 <0> (ø)` | :arrow_down: |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `54.87% <0%> (-6.1%)` | `0% <0%> (ø)` | |
| [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0R5bmFtaWNCcm9rZXJTZWxlY3Rvci5qYXZh) | `69.69% <0%> (-3.04%)` | `0% <0%> (ø)` | |
| [...ces/PinotSegmentUploadDownloadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZERvd25sb2FkUmVzdGxldFJlc291cmNlLmphdmE=) | `61.34% <0%> (+0.61%)` | `0% <0%> (ø)` | :arrow_down: |
| [...e/io/writer/impl/MutableOffHeapByteArrayStore.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NdXRhYmxlT2ZmSGVhcEJ5dGVBcnJheVN0b3JlLmphdmE=) | `85.71% <0%> (+1.09%)` | `0% <0%> (ø)` | :arrow_down: |
| [...g/apache/pinot/common/request/InstanceRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9JbnN0YW5jZVJlcXVlc3QuamF2YQ==) | `28.83% <0%> (+1.14%)` | `0% <0%> (ø)` | :arrow_down: |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `37.8% <0%> (+1.21%)` | `0% <0%> (ø)` | :arrow_down: |
| [...org/apache/pinot/common/metrics/MetricsHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NZXRyaWNzSGVscGVyLmphdmE=) | `48.75% <0%> (+1.25%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [585 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [132009c...226ed77](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on issue #5018: Support
arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
npawar commented on issue #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578952657
How about adding ModuloTransformFunction so that we completely cover SQL arithmetic operators: https://www.w3schools.com/sql/sql_operators.asp
Could be in this PR or as a followup. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5018:
Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/622e00e2c31c7e509fb4f9352cb9c7e57d773ddb?src=pr&el=desc) will **decrease** coverage by `6.74%`.
> The diff coverage is `90.58%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
===========================================
- Coverage 58.55% 51.8% -6.75%
Complexity 12 12
===========================================
Files 1179 1181 +2
Lines 63013 63083 +70
Branches 9274 9282 +8
===========================================
- Hits 36895 32682 -4213
- Misses 23394 27875 +4481
+ Partials 2724 2526 -198
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | `0 <0> (ø)` | |
| [...or/transform/function/ModuloTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTW9kdWxvVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `72.13% <100%> (+2.48%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.2% <86.2%> (ø)` | `0 <0> (?)` | |
| [...ot/minion/events/EventObserverFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0V2ZW50T2JzZXJ2ZXJGYWN0b3J5UmVnaXN0cnkuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...minion/executor/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../apache/pinot/minion/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...nion/events/DefaultMinionEventObserverFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0RlZmF1bHRNaW5pb25FdmVudE9ic2VydmVyRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...executor/ConvertToRawIndexTaskExecutorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [248 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [622e00e...dd2dd77](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5018:
Support arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/132009c311eb72908fe1d25a7218b1b737bda9ef?src=pr&el=desc) will **increase** coverage by `21.1%`.
> The diff coverage is `84.31%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
============================================
+ Coverage 35.92% 57.03% +21.1%
- Complexity 0 12 +12
============================================
Files 1179 1180 +1
Lines 62854 62899 +45
Branches 9231 9233 +2
============================================
+ Hits 22580 35873 +13293
+ Misses 38308 24392 -13916
- Partials 1966 2634 +668
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `91.32% <ø> (+63.16%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | `0 <0> (ø)` | |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `71.66% <100%> (+7.38%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `85.71% <85.71%> (ø)` | `0 <0> (?)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `57.31% <0%> (-3.66%)` | `0% <0%> (ø)` | |
| [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `44.61% <0%> (-1.54%)` | `0% <0%> (ø)` | |
| [.../pinot/core/operator/docidsets/BitmapDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQml0bWFwRG9jSWRTZXQuamF2YQ==) | `84.37% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...not/core/operator/docidsets/SizeBasedDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvU2l6ZUJhc2VkRG9jSWRTZXQuamF2YQ==) | `50% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=) | `55.55% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [590 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [132009c...58f5b26](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5018:
Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/622e00e2c31c7e509fb4f9352cb9c7e57d773ddb?src=pr&el=desc) will **decrease** coverage by `6.67%`.
> The diff coverage is `90.58%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
============================================
- Coverage 58.55% 51.87% -6.68%
Complexity 12 12
============================================
Files 1179 1181 +2
Lines 63013 63083 +70
Branches 9274 9282 +8
============================================
- Hits 36895 32724 -4171
- Misses 23394 27836 +4442
+ Partials 2724 2523 -201
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | `0 <0> (ø)` | |
| [...or/transform/function/ModuloTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTW9kdWxvVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `72.13% <100%> (+2.48%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.2% <86.2%> (ø)` | `0 <0> (?)` | |
| [...ot/minion/events/EventObserverFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0V2ZW50T2JzZXJ2ZXJGYWN0b3J5UmVnaXN0cnkuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...minion/executor/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../apache/pinot/minion/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...nion/events/DefaultMinionEventObserverFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0RlZmF1bHRNaW5pb25FdmVudE9ic2VydmVyRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...executor/ConvertToRawIndexTaskExecutorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [247 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [622e00e...9fe5e90](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5018: Support
arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request
#5018: Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r372065895
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -176,6 +176,14 @@ public void testHardcodedSqlQueries()
testSqlQuery(query, Collections.singletonList(query));
query = "SELECT DaysSinceEpoch, COUNT(*), MAX(ArrTime), MIN(ArrTime) FROM mytable GROUP BY DaysSinceEpoch";
testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
+ testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime - ArrTime % 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
+ testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime + ArrTime * 9 - ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
+ testSqlQuery(query, Collections.singletonList(query));
Review comment:
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5018:
Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/daf02ac82dce2aed403fd1a3ab1796621ba0b185?src=pr&el=desc) will **decrease** coverage by `20.23%`.
> The diff coverage is `52.94%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
=============================================
- Coverage 57.29% 37.06% -20.24%
=============================================
Files 1179 1181 +2
Lines 62955 63024 +69
Branches 9256 9264 +8
=============================================
- Hits 36069 23358 -12711
- Misses 24185 37571 +13386
+ Partials 2701 2095 -606
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `38.98% <ø> (-48.1%)` | `0 <0> (ø)` | |
| [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | `0 <0> (ø)` | |
| [...or/transform/function/ModuloTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTW9kdWxvVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `67.21% <100%> (-2.43%)` | `0 <0> (ø)` | |
| [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.2% <86.2%> (ø)` | `0 <0> (?)` | |
| [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...che/pinot/common/restlet/resources/TablesList.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVzTGlzdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9PcHRpb25zQXN0Tm9kZS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...ot/core/query/scheduler/TableBasedGroupMapper.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvVGFibGVCYXNlZEdyb3VwTWFwcGVyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...t/core/segment/index/readers/OnHeapDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRGljdGlvbmFyeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [586 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [daf02ac...b0d6948](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull
request #5018: Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r372060808
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -176,6 +176,8 @@ public void testHardcodedSqlQueries()
testSqlQuery(query, Collections.singletonList(query));
query = "SELECT DaysSinceEpoch, COUNT(*), MAX(ArrTime), MIN(ArrTime) FROM mytable GROUP BY DaysSinceEpoch";
testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
Review comment:
Can we add tests for nested? e.g ADD(col1 + 5, col2), ADD(col1 * 5, 2)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on a change in pull request
#5018: Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
npawar commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r371956539
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -176,6 +176,8 @@ public void testHardcodedSqlQueries()
testSqlQuery(query, Collections.singletonList(query));
query = "SELECT DaysSinceEpoch, COUNT(*), MAX(ArrTime), MIN(ArrTime) FROM mytable GROUP BY DaysSinceEpoch";
testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
Review comment:
could we add some more queries here which will cover all the arithmetic operators?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request
#5018: Support arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r371267505
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##########
@@ -49,6 +50,10 @@ private TransformFunctionFactory() {
put(SubtractionTransformFunction.FUNCTION_NAME.toLowerCase(), SubtractionTransformFunction.class);
put(MultiplicationTransformFunction.FUNCTION_NAME.toLowerCase(), MultiplicationTransformFunction.class);
put(DivisionTransformFunction.FUNCTION_NAME.toLowerCase(), DivisionTransformFunction.class);
+ put(SqlKind.PLUS.name().toLowerCase(), AdditionTransformFunction.class);
Review comment:
I cannot refer `AdditionTransformFunction` in `pinot-core` from `CalciteSqlParser` in `pinot-common`.
Another option here is that I can create a `PlusTransformFunction` extends `AdditionTransformFunction`, by just overriding the function name to `plus`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5018:
Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/622e00e2c31c7e509fb4f9352cb9c7e57d773ddb?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `90.58%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
============================================
+ Coverage 58.55% 58.57% +0.02%
Complexity 12 12
============================================
Files 1179 1181 +2
Lines 63013 63082 +69
Branches 9274 9281 +7
============================================
+ Hits 36895 36953 +58
- Misses 23394 23404 +10
- Partials 2724 2725 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | `0 <0> (ø)` | |
| [...or/transform/function/ModuloTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTW9kdWxvVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `72.13% <100%> (+2.48%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.2% <86.2%> (ø)` | `0 <0> (?)` | |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `57.31% <0%> (-13.42%)` | `0% <0%> (ø)` | |
| [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvT3JCbG9ja0RvY0lkU2V0LmphdmE=) | `84.9% <0%> (-9.44%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `60.21% <0%> (-8.61%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `56.98% <0%> (-8.61%)` | `0% <0%> (ø)` | |
| [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0%> (-7.15%)` | `0% <0%> (ø)` | |
| [...query/aggregation/groupby/utils/DoubleToIdMap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L3V0aWxzL0RvdWJsZVRvSWRNYXAuamF2YQ==) | `68.75% <0%> (-6.25%)` | `0% <0%> (ø)` | |
| ... and [29 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [622e00e...ac1002d](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull
request #5018: Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r372062373
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -176,6 +176,14 @@ public void testHardcodedSqlQueries()
testSqlQuery(query, Collections.singletonList(query));
query = "SELECT DaysSinceEpoch, COUNT(*), MAX(ArrTime), MIN(ArrTime) FROM mytable GROUP BY DaysSinceEpoch";
testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
+ testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime - ArrTime % 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
+ testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime + ArrTime * 9 - ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
+ testSqlQuery(query, Collections.singletonList(query));
Review comment:
Can we add tests for nested? e.g ADD(col1 + 5, col2), ADD(col1 * 5, col2)?
Also, expressions with parentheses?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on issue #5018: Support
arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
kishoreg commented on issue #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578773616
If it’s easy to move transform function names to common? We already have aggregation function types in common.
If not, Lets have a mapping function table in calcite sql parser for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull
request #5018: Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r372060808
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -176,6 +176,8 @@ public void testHardcodedSqlQueries()
testSqlQuery(query, Collections.singletonList(query));
query = "SELECT DaysSinceEpoch, COUNT(*), MAX(ArrTime), MIN(ArrTime) FROM mytable GROUP BY DaysSinceEpoch";
testSqlQuery(query, Collections.singletonList(query));
+ query = "SELECT ArrTime, ArrTime * 10 FROM mytable WHERE DaysSinceEpoch >= 16312";
Review comment:
Can we add tests for nested? e.g ADD(col1 + 5, col2), ADD(col1 * 5, 2)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on a change in pull request
#5018: Support arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r371260811
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##########
@@ -49,6 +50,10 @@ private TransformFunctionFactory() {
put(SubtractionTransformFunction.FUNCTION_NAME.toLowerCase(), SubtractionTransformFunction.class);
put(MultiplicationTransformFunction.FUNCTION_NAME.toLowerCase(), MultiplicationTransformFunction.class);
put(DivisionTransformFunction.FUNCTION_NAME.toLowerCase(), DivisionTransformFunction.class);
+ put(SqlKind.PLUS.name().toLowerCase(), AdditionTransformFunction.class);
Review comment:
It’s probably better to change the function name in calcite sql parser to match Pinot functions. This will restrict calcite classes to parsing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5018:
Support arithmetic operators like '+', '-', '*', '/', '%'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5018: Support arithmetic operators like '+','-','*','/','%'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578497721
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=h1) Report
> Merging [#5018](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/daf02ac82dce2aed403fd1a3ab1796621ba0b185?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `90.58%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5018 +/- ##
============================================
+ Coverage 57.29% 57.31% +0.02%
Complexity 12 12
============================================
Files 1179 1181 +2
Lines 62955 63024 +69
Branches 9256 9264 +8
============================================
+ Hits 36069 36124 +55
- Misses 24185 24213 +28
+ Partials 2701 2687 -14
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `88.13% <ø> (+1.05%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==) | `44.44% <0%> (-35.56%)` | `0 <0> (ø)` | |
| [...or/transform/function/ModuloTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTW9kdWxvVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...r/transform/function/TransformFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25GYWN0b3J5LmphdmE=) | `72.13% <100%> (+2.48%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/common/function/TransformFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | `86.2% <86.2%> (ø)` | `0 <0> (?)` | |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `29.48% <0%> (-42.31%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `53.76% <0%> (-9.68%)` | `0% <0%> (ø)` | |
| [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `23.68% <0%> (-7.9%)` | `0% <0%> (ø)` | |
| [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0R5bmFtaWNCcm9rZXJTZWxlY3Rvci5qYXZh) | `69.69% <0%> (-3.04%)` | `0% <0%> (ø)` | |
| [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `47.61% <0%> (-2.39%)` | `0% <0%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/incubator-pinot/pull/5018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=footer). Last update [daf02ac...b0d6948](https://codecov.io/gh/apache/incubator-pinot/pull/5018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5018: Support
arithmetic operators like '+', '-', '*', '/'
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on issue #5018: Support arithmetic operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#issuecomment-578947412
> If it’s easy to move transform function names to common? We already have aggregation function types in common.
>
> If not, Lets have a mapping function table in calcite sql parser for now
Created `TransformFunctionType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org