You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/07/19 07:52:25 UTC
[GitHub] [incubator-pekko-http] jrudolph opened a new pull request, #246: add extra license header to DateTime.scala corresponding to note in LICENSE
jrudolph opened a new pull request, #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] justinmclean commented on pull request #246: add extra license header to DateTime.scala corresponding to note in LICENSE
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246#issuecomment-1641772346
Without permission no, so probably best to leave it there, it's unfortunate they copies someone else code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #246: add extra license header to DateTime.scala corresponding to note in LICENSE
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246#issuecomment-1641685224
> I would assume as this is 3rd party code it's not copyright Lightbend Inc or the ASF??
Its code that was written by Lightbend that was based off of ASF code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #246: add extra license header to DateTime.scala corresponding to note in LICENSE
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246#issuecomment-1641694831
@justinmclean the Lightbend license appears in the file we inherited from Akka, how can we remove it?
See https://github.com/akka/akka-http/blob/f54a8de66458cd623675a5a2d8167cd2673d6ce5/akka-http-core/src/main/scala/akka/http/scaladsl/model/DateTime.scala#L1-L3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #246: add extra license header to DateTime.scala corresponding to note in LICENSE
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246#issuecomment-1641771395
This was also clearly decided upon in https://issues.apache.org/jira/browse/LEGAL-626, we are not allowed to remove the existing Lightbend copyright header from code that was taken from Akka (which is the case here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #246: add extra license header to DateTime.scala corresponding to note in LICENSE
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246#issuecomment-1641814630
This was at length discussed before. No code was copied, but some parts of the algorithm were based on existing code/ideas which is common best practice. What is not so common, is to be so diligent to keep a reference of what happened here and to later go to the extreme lengths of contacting the orginal author of >20 year old code that is not online anymore and get his permission to use the algorithms that are likely not copyrightable anyways.
The licensing risk of all the places where references are annotated goes towards zero compared to all the places where we will have to take the existing copyright header for granted for all the code below them. We cannot transitively check if code we received under a license has been contributed without copying some code or ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #246: add extra license header to DateTime.scala corresponding to note in LICENSE
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] justinmclean commented on pull request #246: add extra license header to DateTime.scala corresponding to note in LICENSE
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #246:
URL: https://github.com/apache/incubator-pekko-http/pull/246#issuecomment-1641680688
I would assume as this is 3rd party code it's not copyright Lightbend Inc or the ASF??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org