You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org> on 2010/05/17 16:03:41 UTC
[jira] Created: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
AMQPException messages contain duplicate AMQConstant text
---------------------------------------------------------
Key: QPID-2608
URL: https://issues.apache.org/jira/browse/QPID-2608
Project: Qpid
Issue Type: Bug
Components: Java Broker, Java Client
Affects Versions: 0.6, 0.5
Reporter: Andrew Kennedy
Priority: Minor
Fix For: 0.7
The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870614#action_12870614 ]
Robbie Gemmell commented on QPID-2608:
--------------------------------------
Appled patch: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-2608:
------------------------------------
Assignee: Robbie Gemmell
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2608:
---------------------------------
Attachment: 0001-QPID-2608-Update-test-to-reflect-changes-to-excepti.patch
Updated ExternalACLJMXTest to reflect changes in the AMQException toString method when examining exception stacktraces
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch, 0001-QPID-2608-Update-test-to-reflect-changes-to-excepti.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-2608:
---------------------------------
Status: Ready To Review (was: In Progress)
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2608:
---------------------------------
Attachment: 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch
Removed reference to AMQSecurityException
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2608:
---------------------------------
Attachment: (was: 0004-QPID-2608-AMQPException-messages-contain-duplicate.patch)
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2608:
---------------------------------
Attachment: (was: 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch)
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2608:
---------------------------------
Attachment: (was: 0001-QPID-2608-Update-test-to-reflect-changes-to-excepti.patch)
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2608:
---------------------------------
Attachment: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
Updated patch based on review comments
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-2608.
----------------------------------
Resolution: Fixed
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2608:
---------------------------------
Attachment: 0004-QPID-2608-AMQPException-messages-contain-duplicate.patch
Move message extraction from AMQPConstant to toString and added an AMQPSecurityException subclass
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0004-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2608) AMQPException messages contain
duplicate AMQConstant text
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870581#action_12870581 ]
Robbie Gemmell commented on QPID-2608:
--------------------------------------
The override on toString() to clean up the error code cloning in cloneForCurrentThread() doesnt print the class name as the standard Throwable output would, it would be good to put this back in.
> AMQPException messages contain duplicate AMQConstant text
> ---------------------------------------------------------
>
> Key: QPID-2608
> URL: https://issues.apache.org/jira/browse/QPID-2608
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.5, 0.6
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0003-QPID-2608-AMQPException-messages-contain-duplicate.patch
>
>
> The AMQPException class builds the message string in the constructor. Nested eceptions can cause the mssage text taken from AMQPConstant to be duplicated (possibly several times). The message should be build in the toString method instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org