You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chemistry.apache.org by Florent Guillaume <fg...@nuxeo.com> on 2014/10/23 15:41:40 UTC

stopAfterService

Florian,

The stopAfterService implementations for the three bindings delegate to
beforeServiceCall... It's a typo, right, and should be afterServiceCall?

    protected boolean stopAfterService(CmisService service) {

        if (!(service instanceof ProgressControlCmisService)) {

            return false;

        }

       return ((ProgressControlCmisService) service).beforeServiceCall() ==
Progress.STOP;

    }

Florent

-- 
Florent Guillaume, Director of R&D, Nuxeo
Open Source Content Management Platform for Business Apps
http://www.nuxeo.com   http://community.nuxeo.com

Re: stopAfterService

Posted by Florent Guillaume <fg...@nuxeo.com>.
I'll open a JIRA. I can do the fix it's all right.

Florent

On Thu, Oct 23, 2014 at 3:58 PM, Florian Müller <fm...@apache.org> wrote:
> Hi Florent,
>
> Yes, that is a typo. Please open an issue in JIRA. I'll fix it.
>
>
> - Florian
>
>
>
>> Florian,
>>
>> The stopAfterService implementations for the three bindings delegate to
>> beforeServiceCall... It's a typo, right, and should be afterServiceCall?
>>
>>     protected boolean stopAfterService(CmisService service) {
>>
>>         if (!(service instanceof ProgressControlCmisService)) {
>>
>>             return false;
>>
>>         }
>>
>>        return ((ProgressControlCmisService) service).beforeServiceCall()
>> ==
>> Progress.STOP;
>>
>>     }
>>
>> Florent



-- 
Florent Guillaume, Director of R&D, Nuxeo
Open Source Content Management Platform for Business Apps
http://www.nuxeo.com   http://community.nuxeo.com

Re: stopAfterService

Posted by Florian Müller <fm...@apache.org>.
Hi Florent,

Yes, that is a typo. Please open an issue in JIRA. I'll fix it.


- Florian


> Florian,
> 
> The stopAfterService implementations for the three bindings delegate to
> beforeServiceCall... It's a typo, right, and should be 
> afterServiceCall?
> 
>     protected boolean stopAfterService(CmisService service) {
> 
>         if (!(service instanceof ProgressControlCmisService)) {
> 
>             return false;
> 
>         }
> 
>        return ((ProgressControlCmisService) 
> service).beforeServiceCall() ==
> Progress.STOP;
> 
>     }
> 
> Florent