[GitHub] [buildstream] gtristan commented on issue #1798: Error out in situations where conditional statements `(?)` can never evaluate `true`

[GitBox <gi...@apache.org>]

gtristan commented on issue #1798:
URL: https://github.com/apache/buildstream/issues/1798#issuecomment-1340634224

   > This is IMHO not a BuildStream bug in the end. It is expected behaviour that BuildStream does not error if conditionals do not match. There is no if-elif-else construct available. It turns out there are two bugs here in freedesktop-sdk: one was the x86-64 vs x86_64 and the other is that aarch64 was missing completely. I will fix both.
   
   Right, there is nothing we could do about unhandled `aarch64`, however we *do* know that an enum project option (or an arch option) can only have specific values, and we *could* potentially detect a situation where you are checking an expression which could never be true.
   
   IMO this could have saved some time with an early error.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org