You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ankitsultana (via GitHub)" <gi...@apache.org> on 2023/04/12 20:54:44 UTC
[GitHub] [pinot] ankitsultana opened a new pull request, #10596: [multistage] Handle Integer.MIN_VALUE in hashCode based FieldSelectionKeySelector
ankitsultana opened a new pull request, #10596:
URL: https://github.com/apache/pinot/pull/10596
Saw this in our production where one of the inputs hashes to `Integer.MIN_VALUE`.
`Math.abs` returns negation of the input number if the input number is negative. So for `Integer.MIN_VALUE`, it returns the same value. This is also documented in the docs for `Math.abs`.
In other places like `MurmurPartitionFunction`, `HashCodePartitionFunction`, etc. we seem to be already doing this so looks like it's a known thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10596: [multistage] Handle Integer.MIN_VALUE in FieldSelectionKeySelector
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10596:
URL: https://github.com/apache/pinot/pull/10596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10596: [multistage] Handle Integer.MIN_VALUE in FieldSelectionKeySelector
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10596:
URL: https://github.com/apache/pinot/pull/10596#issuecomment-1506011496
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10596?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10596](https://codecov.io/gh/apache/pinot/pull/10596?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e585755) into [master](https://codecov.io/gh/apache/pinot/commit/7c1d10a358b4974b3ddc0b56c8d4328e0d6d579c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1d10a) will **decrease** coverage by `41.29%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10596 +/- ##
=============================================
- Coverage 69.04% 27.75% -41.29%
+ Complexity 6496 58 -6438
=============================================
Files 2106 2090 -16
Lines 113004 112572 -432
Branches 17026 16971 -55
=============================================
- Hits 78021 31243 -46778
- Misses 29495 78213 +48718
+ Partials 5488 3116 -2372
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.46% <0.00%> (?)` | |
| integration2 | `24.04% <0.00%> (-0.11%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lanner/partitioning/FieldSelectionKeySelector.java](https://codecov.io/gh/apache/pinot/pull/10596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9wYXJ0aXRpb25pbmcvRmllbGRTZWxlY3Rpb25LZXlTZWxlY3Rvci5qYXZh) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
... and [1550 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10596/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ankitsultana commented on pull request #10596: [multistage] Handle Integer.MIN_VALUE in FieldSelectionKeySelector
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on PR #10596:
URL: https://github.com/apache/pinot/pull/10596#issuecomment-1506118577
> LG. can you check test failure?
Thanks. Filed a separate issue for it: https://github.com/apache/pinot/issues/10597
It might be a flaky test. The code change in this is unrelated since `FieldSelectionKeySelector` is only used for multistage queries during query execution, and the error in the UT was from some pulsar consumer test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org