You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Ames <gr...@raleigh.ibm.com> on 2000/07/12 23:23:52 UTC
[PATCH] fix prefork
fix recent breakage
Greg
Index: modules/mpm/prefork/prefork.c
===================================================================
RCS file: /cvs/apache/apache-2.0/src/modules/mpm/prefork/prefork.c,v
retrieving revision 1.117
diff -u -d -b -r1.117 prefork.c
--- prefork.c 2000/07/11 22:12:17 1.117
+++ prefork.c 2000/07/12 21:21:32
@@ -1288,7 +1288,7 @@
ap_log_pid(pconf, ap_pid_fname);
- if (ap_setup_listeners(s)) {
+ if (!ap_setup_listeners(s)) {
/* XXX: hey, what's the right way for the mpm to indicate a
fatal error? */
return 1;
}
Re: [PATCH] fix prefork
Posted by Greg Ames <gr...@raleigh.ibm.com>.
Greg Stein wrote:
>
> Unfortunately, that isn't quite enough. The listenmaxfd and listenfds
> globals need to be set up properly.
>
> I just reversed the change for setup_listeners(), so prefork should be back
> to its original state (although a couple other changes have since gone in
> since then... no guarantees from me).
>
> Please try it out.
>
> Cheers,
> -g
Ooooops - thanks for the review :-) It was serving pages for me, but
I'll try out yours ASAP.
Greg
Re: [PATCH] fix prefork
Posted by Greg Stein <gs...@lyra.org>.
Unfortunately, that isn't quite enough. The listenmaxfd and listenfds
globals need to be set up properly.
I just reversed the change for setup_listeners(), so prefork should be back
to its original state (although a couple other changes have since gone in
since then... no guarantees from me).
Please try it out.
Cheers,
-g
On Wed, Jul 12, 2000 at 05:23:52PM -0400, Greg Ames wrote:
> fix recent breakage
>
> Greg
>
> Index: modules/mpm/prefork/prefork.c
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/modules/mpm/prefork/prefork.c,v
> retrieving revision 1.117
> diff -u -d -b -r1.117 prefork.c
> --- prefork.c 2000/07/11 22:12:17 1.117
> +++ prefork.c 2000/07/12 21:21:32
> @@ -1288,7 +1288,7 @@
>
> ap_log_pid(pconf, ap_pid_fname);
>
> - if (ap_setup_listeners(s)) {
> + if (!ap_setup_listeners(s)) {
> /* XXX: hey, what's the right way for the mpm to indicate a
> fatal error? */
> return 1;
> }
--
Greg Stein, http://www.lyra.org/