You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/06 09:59:09 UTC

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #343: test: add DP test cases in traffic split e2e

gxthrj commented on a change in pull request #343:
URL: https://github.com/apache/apisix-ingress-controller/pull/343#discussion_r607711666



##########
File path: test/e2e/features/traffic_split.go
##########
@@ -47,47 +49,44 @@ spec:
      hosts:
      - httpbin.org
      paths:
-       - /ip
+       - /get
    backends:
    - serviceName: %s
      servicePort: %d
      weight: 10
-   - serviceName: %s
-     servicePort: %d
+   - serviceName: apisix-service-e2e-test
+     servicePort: 9180
      weight: 5
-`, backendSvc, backendPorts[0], backendSvc, backendPorts[0])
+`, backendSvc, backendPorts[0])

Review comment:
       Why not use variables?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org