You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/02/12 22:32:53 UTC
[PR] [MINOR][PYTHON] Fix typo: convert_timestample -> convert_timestamp [spark]
Yicong-Huang opened a new pull request, #54289:
URL: https://github.com/apache/spark/pull/54289
### What changes were proposed in this pull request?
Fix typo in internal function names: `convert_timestample` → `convert_timestamp` and `convert_timestample_ntz` → `convert_timestamp_ntz` in `ArrowTableToRowsConversion._create_converter`.
### Why are the changes needed?
The typo was introduced in SPARK-41746 (`5e0a82e590d`) and later moved as-is in SPARK-51206. These are internal closure names so there's no functional impact, but fixing the spelling improves readability.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No test changes needed — internal function name only.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][PYTHON] Fix typo: convert_timestample -> convert_timestamp [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #54289: [MINOR][PYTHON] Fix typo: convert_timestample -> convert_timestamp
URL: https://github.com/apache/spark/pull/54289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][PYTHON] Fix typo: convert_timestample -> convert_timestamp [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #54289:
URL: https://github.com/apache/spark/pull/54289#issuecomment-3894532132
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org