You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/12/29 20:10:16 UTC

[GitHub] [nifi] mattyb149 commented on a change in pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components

mattyb149 commented on a change in pull request #4682:
URL: https://github.com/apache/nifi/pull/4682#discussion_r549832554



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTableRecord.java
##########
@@ -44,7 +44,7 @@
 import java.util.List;
 import java.util.Set;
 
-import static org.apache.nifi.processors.standard.util.JdbcProperties.USE_AVRO_LOGICAL_TYPES;
+import static org.apache.nifi.util.db.JdbcProperties.USE_AVRO_LOGICAL_TYPES;

Review comment:
       I need to add the registry-only properties to this processor and change QueryDatabaseTable to use the registry-only properties as well. This will involve moving the registry-only properties out of the metrics utils class and into JdbcProperties




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org