You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebint (via GitHub)" <gi...@apache.org> on 2024/03/19 06:27:56 UTC
[I] Chart Holder Full Screen is not working [superset]
sebint opened a new issue, #27561:
URL: https://github.com/apache/superset/issues/27561
### Bug description
Unable to enter into Fullscreen state in chart container due to
```
const DragDroppableStyles = styled.div`
${({ theme }) => css`
position: relative;
/*
Next line is a workaround for a bug in react-dnd where the drag
preview expands outside of the bounds of the drag source card, see:
https://github.com/react-dnd/react-dnd/issues/832#issuecomment-442071628
*/
transform: translate3d(0, 0, 0);
```
When I remove `transform: translate3d(0, 0, 0);` Its working.
Since its a fix for react-dnd, I would like to know if there are other solutions.
### How to reproduce the bug
1. Go to any dashboard.
2. Go to any chart slice in the dashboard
3. Click on the slice control
4. Click on dropdown item "Enter fullscreen"
### Screenshots/recordings
**Default View**
**Clicked on "Enter Fullscreen"**
### Superset version
master / latest-dev
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "maybeyourking (via GitHub)" <gi...@apache.org>.
maybeyourking commented on issue #27561:
URL: https://github.com/apache/superset/issues/27561#issuecomment-2008922106
I also had the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #27561:
URL: https://github.com/apache/superset/issues/27561#issuecomment-2013016693
@justinpark do you recall the specifics of that line? I'm guessing it's the GPU hack for the browser, but maybe not. If you know a reliable way to test the original bug you were chasing, I can throw some other CSS approaches at it and hopefully open a PR to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #27561: Chart Holder Full Screen is not working
URL: https://github.com/apache/superset/issues/27561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #27561:
URL: https://github.com/apache/superset/issues/27561#issuecomment-2014923630
Fixed by https://github.com/apache/superset/pull/27613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #27561:
URL: https://github.com/apache/superset/issues/27561#issuecomment-2013016108
@justinpark do you recall the specifics of that line? I'm guessing it's the GPU hack for the browser, but maybe not. If you know a reliable way to test the original bug you were chasing, I can throw some other CSS approaches at it and hopefully open a PR to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on issue #27561:
URL: https://github.com/apache/superset/issues/27561#issuecomment-2012997519
relates to this PR: https://github.com/apache/superset/pull/27308 if it is `transform: translate3d(0, 0, 0);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #27561:
URL: https://github.com/apache/superset/issues/27561#issuecomment-2010774354
This probably isn't _related_ necessarily, but could be a "two birds, one stone" situation:
https://github.com/apache/superset/issues/24752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Chart Holder Full Screen is not working [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on issue #27561:
URL: https://github.com/apache/superset/issues/27561#issuecomment-2010814450
Heads up this isn't happening with 4.0rc1 from what I can tell from the ephemeral in the PR. So It's probably one of the commits that's happening afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org