You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/11/18 11:16:20 UTC

[GitHub] [calcite] asolimando commented on a change in pull request #2267: Following [CALCITE-4354], added 'calcite.experimental.allow.field.ind…

asolimando commented on a change in pull request #2267:
URL: https://github.com/apache/calcite/pull/2267#discussion_r526006792



##########
File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##########
@@ -131,6 +131,15 @@
   public static final CalciteSystemProperty<Boolean> TOPDOWN_OPT =
       booleanProperty("calcite.planner.topdown.opt", false);
 
+  /**
+   * Whether to enable index-based access for struct fields.
+   *
+   * <p>Note: the feature is experimental as it relies on field order which is JVM-dependent
+   * (see CALCITE-2489).</p>
+   */
+  public static final CalciteSystemProperty<Boolean> ALLOW_FIELD_INDEX_ACCESS =
+      booleanProperty("calcite.experimental.allow.field.index.access", false);

Review comment:
       I agree on the property renaming, in light of the new name I have also moved it in the same group as the other "calcite.enable.enumerable.*" ones.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org