You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/20 14:56:03 UTC

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2292: tinyusb: Add standard descriptor for BT HCI

apache-mynewt-bot removed a comment on pull request #2292:
URL: https://github.com/apache/mynewt-core/pull/2292#issuecomment-631500689


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/usb/tinyusb/nrf5x/include/tusb_hw.h
   <details>
   
   ```diff
   @@ -79,7 +79,7 @@
    #endif
    
    #if defined(MYNEWT_VAL_USBD_BTH_EVENT_EP_SIZE)
   -#defined BTH_EVENT_EP_SIZE      MYNEWT_VAL(BTH_EVENT_EP_SIZE)
   +#defined BTH_EVENT_EP_SIZE MYNEWT_VAL(BTH_EVENT_EP_SIZE)
    #else
    #define USBD_BTH_EVENT_EP_SIZE  0x10
    #endif
   ```
   
   </details>
   
   #### hw/usb/tinyusb/std_descriptors/src/std_descriptors.c
   <details>
   
   ```diff
   @@ -190,7 +190,8 @@
                              MYNEWT_VAL(USBD_CONFIGURATION_MAX_POWER)),
    
    #if CFG_TUD_BTH
   -    TUD_BTH_DESCRIPTOR(ITF_NUM_BTH, BTH_IF_STR_IX, USBD_BTH_EVENT_EP, USBD_BTH_EVENT_EP_SIZE, USBD_BTH_EVENT_EP_INTERVAL,
   +    TUD_BTH_DESCRIPTOR(ITF_NUM_BTH, BTH_IF_STR_IX, USBD_BTH_EVENT_EP, USBD_BTH_EVENT_EP_SIZE,
   +                       USBD_BTH_EVENT_EP_INTERVAL,
                           USBD_BTH_DATA_IN_EP, USBD_BTH_DATA_OUT_EP, USBD_BTH_DATA_EP_SIZE, 0, 9, 17, 25, 33, 49),
    #endif
    
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org