Ready to submit a small patch

[Steve Lee <st...@opendirective.com>]

I'm looking forward to submitting my first (trivial) patch to the
templates but have a quick question before I do so.

I'll obviously wait for the release to be completed, but wonder if I
should create a bug first for the commit, or just commit it first with
suitable comments?

Steve Lee
Programme Leader (Open Accessibility)
OpenDirective http://opendirective.com

Re: Ready to submit a small patch

[Steve Lee <st...@fullmeasure.co.uk>]

Even given 'user' is open to some interpretation it's unlikely to be
very interesting to developers simply using the templates. However the
issue it fixes is obscure and could possibly be of wider interest. I
had decided to create a Jira anyway...

Steve

On 9 April 2013 12:33, Ross Gardler <rg...@opendirective.com> wrote:
> Sure, but in this case Steve said it was a trivial patch. That implies end
> users will not be interested. Sometimes creating an issue takes more effort
> than fixing the trivial item discovered.
>
> Of course, one should always do a JIRA search to make sure another user has
> not discovered the trivial issue.
>
> Steve, Martin makes a good point, if it is interesting to a user create an
> issue, if it is truly trivial don't bother.
>
> Ross
>
>
> On 9 April 2013 11:53, Martin Grigorov <mg...@apache.org> wrote:
>
>> Hi,
>>
>> Having an issue is more for the end users IMO.
>> This way the users can see what has changed between two releases.
>>
>>
>> On Tue, Apr 9, 2013 at 1:38 PM, Ross Gardler <rgardler@opendirective.com
>> >wrote:
>>
>> > No need to wait for release. We are not in code freeze.
>> >
>> > Form trivial patches don't worry about an issue for Wookie. Other
>> projects
>> > want an issue for everything.
>> >
>> > Sent from a mobile device, please excuse mistakes and brevity
>> > On 9 Apr 2013 11:00, "Steve Lee" <st...@opendirective.com> wrote:
>> >
>> > > I'm looking forward to submitting my first (trivial) patch to the
>> > > templates but have a quick question before I do so.
>> > >
>> > > I'll obviously wait for the release to be completed, but wonder if I
>> > > should create a bug first for the commit, or just commit it first with
>> > > suitable comments?
>> > >
>> > > Steve Lee
>> > > Programme Leader (Open Accessibility)
>> > > OpenDirective http://opendirective.com
>> > >
>> >
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com <http://jweekend.com/>
>>
>
>
>
> --
> Ross Gardler (@rgardler)
> Programme Leader (Open Development)
> OpenDirective http://opendirective.com

Re: Ready to submit a small patch

[Ross Gardler <rg...@opendirective.com>]

Sure, but in this case Steve said it was a trivial patch. That implies end
users will not be interested. Sometimes creating an issue takes more effort
than fixing the trivial item discovered.

Of course, one should always do a JIRA search to make sure another user has
not discovered the trivial issue.

Steve, Martin makes a good point, if it is interesting to a user create an
issue, if it is truly trivial don't bother.

Ross


On 9 April 2013 11:53, Martin Grigorov <mg...@apache.org> wrote:

> Hi,
>
> Having an issue is more for the end users IMO.
> This way the users can see what has changed between two releases.
>
>
> On Tue, Apr 9, 2013 at 1:38 PM, Ross Gardler <rgardler@opendirective.com
> >wrote:
>
> > No need to wait for release. We are not in code freeze.
> >
> > Form trivial patches don't worry about an issue for Wookie. Other
> projects
> > want an issue for everything.
> >
> > Sent from a mobile device, please excuse mistakes and brevity
> > On 9 Apr 2013 11:00, "Steve Lee" <st...@opendirective.com> wrote:
> >
> > > I'm looking forward to submitting my first (trivial) patch to the
> > > templates but have a quick question before I do so.
> > >
> > > I'll obviously wait for the release to be completed, but wonder if I
> > > should create a bug first for the commit, or just commit it first with
> > > suitable comments?
> > >
> > > Steve Lee
> > > Programme Leader (Open Accessibility)
> > > OpenDirective http://opendirective.com
> > >
> >
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com <http://jweekend.com/>
>



-- 
Ross Gardler (@rgardler)
Programme Leader (Open Development)
OpenDirective http://opendirective.com

Re: Ready to submit a small patch

[Martin Grigorov <mg...@apache.org>]

Hi,

Having an issue is more for the end users IMO.
This way the users can see what has changed between two releases.


On Tue, Apr 9, 2013 at 1:38 PM, Ross Gardler <rg...@opendirective.com>wrote:

> No need to wait for release. We are not in code freeze.
>
> Form trivial patches don't worry about an issue for Wookie. Other projects
> want an issue for everything.
>
> Sent from a mobile device, please excuse mistakes and brevity
> On 9 Apr 2013 11:00, "Steve Lee" <st...@opendirective.com> wrote:
>
> > I'm looking forward to submitting my first (trivial) patch to the
> > templates but have a quick question before I do so.
> >
> > I'll obviously wait for the release to be completed, but wonder if I
> > should create a bug first for the commit, or just commit it first with
> > suitable comments?
> >
> > Steve Lee
> > Programme Leader (Open Accessibility)
> > OpenDirective http://opendirective.com
> >
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>

Re: Ready to submit a small patch

[Ross Gardler <rg...@opendirective.com>]

No need to wait for release. We are not in code freeze.

Form trivial patches don't worry about an issue for Wookie. Other projects
want an issue for everything.

Sent from a mobile device, please excuse mistakes and brevity
On 9 Apr 2013 11:00, "Steve Lee" <st...@opendirective.com> wrote:

> I'm looking forward to submitting my first (trivial) patch to the
> templates but have a quick question before I do so.
>
> I'll obviously wait for the release to be completed, but wonder if I
> should create a bug first for the commit, or just commit it first with
> suitable comments?
>
> Steve Lee
> Programme Leader (Open Accessibility)
> OpenDirective http://opendirective.com
>