You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/09/26 13:24:02 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1119: [KYUUBI #1039] Kill yarn job when engine initialize timeout and yarnApplicationState is ACCEPTED

yaooqinn commented on a change in pull request #1119:
URL: https://github.com/apache/incubator-kyuubi/pull/1119#discussion_r716204033



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
##########
@@ -49,18 +48,9 @@ trait ProcBuilder {
 
   protected def env: Map[String, String] = conf.getEnvs
 
-  protected val workingDir: Path
-
-  final lazy val processBuilder: ProcessBuilder = {
-    val pb = new ProcessBuilder(commands: _*)
+  protected def launcher: SparkLauncher

Review comment:
       can SparkLauncher be able to launch the coming Flink SQL eninge?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org