[GitHub] [beam] rshamunov commented on a diff in pull request #26513: Playground deployment triggers

["rshamunov (via GitHub)" <gi...@apache.org>]

rshamunov commented on code in PR #26513:
URL: https://github.com/apache/beam/pull/26513#discussion_r1187223996


##########
playground/infrastructure/cloudbuild/cloudbuild_playground_infra.sh:
##########
@@ -40,6 +40,8 @@ git clone --branch $BRANCH_NAME $REPO_NAME --single-branch
 cd beam
 mkdir playground/terraform/environment/$ENVIRONMENT_NAME
  
+gcloud create bucket gs://$TF_VAR_state_bucket --location $TF_VAR_region --project $TF_VAR_project_id --pap

Review Comment:
   Check return value and exit the script if bucket can't be created. We should consider the case when the name is not unique



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org