You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "bkkothari2255 (via GitHub)" <gi...@apache.org> on 2026/01/23 19:32:32 UTC

[PR] SLING-13072: [Sling Models] Migrate defaults and inheritance root tests to JUnit 5 [sling-org-apache-sling-models-impl]

bkkothari2255 opened a new pull request, #76:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/76

   Issue: SLING-13072
   
   Migrated 7 test classes handling defaults, inheritance, and invalid adaptations to JUnit5:
       * `DefaultInterfaceMethodTest`
       * `DefaultTest`
       * `ExtraDefaultTests`
       * `ImplementsExtendsTest`
       * `InjectorSpecificAnnotationTest`
       * `InterfaceInheritanceTest`
       * `InvalidAdaptationsTest`
      
    - Changes
   
       * Replaced `MockitoJUnitRunner` with `@ExtendWith(MockitoExtension.class)`.
       * Applied lenient() stubbing to preserve legacy test behavior.
       * Updated imports to `org.junit.jupiter.api`.
       * Converted `@Test(expected)` to `assertThrows()`.
       * Switched to `doReturn().when()` where necessary to resolve generic type inference issues.
       * Added `<?>` wildcards to raw `Type` variables to fix compiler warnings.
       * Split large test methods to improve readability and assertion tracking.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13072: [Sling Models] Migrate defaults and inheritance root tests to JUnit 5 [sling-org-apache-sling-models-impl]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #76:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/76#issuecomment-3792033506

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=76) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=76&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=76&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl&pullRequest=76&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=76&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=76&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=76)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13072: [Sling Models] Migrate defaults and inheritance root tests to JUnit 5 [sling-org-apache-sling-models-impl]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert merged PR #76:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/76


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org