You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/25 02:55:17 UTC

[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #11637: [Improvement][Test] Block the usage of `Powermock`

EricGao888 opened a new issue, #11637:
URL: https://github.com/apache/dolphinscheduler/issues/11637

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   * We could block the usage of `Powermock` by `Spotless`.
   * Change the pre-commit hook from `mvn spotless:apply` to `mvn spotless:check` to avoid confusing.
   
   related: #11405 
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on issue #11637: [Improvement][Test] Block the usage of `Powermock`

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11637:
URL: https://github.com/apache/dolphinscheduler/issues/11637#issuecomment-1274024492

   BTW, we need to move these two dependencies from each module to root module.
   https://github.com/apache/dolphinscheduler/blob/18ef0a66cb91d9dfe6406f8ade6cfb2cff36492e/dolphinscheduler-common/pom.xml#L63-L74


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11637: [Improvement][Test] Block the usage of `Powermock`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11637:
URL: https://github.com/apache/dolphinscheduler/issues/11637#issuecomment-1226710472

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 closed issue #11637: [Improvement][Test] Block the usage of `Powermock`

Posted by GitBox <gi...@apache.org>.
EricGao888 closed issue #11637: [Improvement][Test] Block the usage of `Powermock`
URL: https://github.com/apache/dolphinscheduler/issues/11637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org