[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #5913: Core: Add dataSequenceNumber to ManifestEntry

[GitBox <gi...@apache.org>]

aokolnychyi commented on code in PR #5913:
URL: https://github.com/apache/iceberg/pull/5913#discussion_r990425264


##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -147,15 +151,16 @@ void existing(ManifestEntry<F> entry) {
    * <p>The entry's snapshot ID will be this manifest's snapshot ID.
    *
    * @param deletedFile a file
+   * @param dataSequenceNumber a data sequence number for the file
    */
-  public void delete(F deletedFile) {
-    addEntry(reused.wrapDelete(snapshotId, deletedFile));
+  public void delete(F deletedFile, long dataSequenceNumber) {

Review Comment:
   Let's throw an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org