You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/08/04 16:48:18 UTC

[GitHub] [druid] gianm commented on a diff in pull request #12859: Add export parameters for Java 11

gianm commented on code in PR #12859:
URL: https://github.com/apache/druid/pull/12859#discussion_r938032759


##########
examples/bin/run-java:
##########
@@ -40,6 +40,11 @@ then
     --add-opens=java.base/java.lang=ALL-UNNAMED \
     --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED \
     "$@"
+elif [ "$JAVA_MAJOR" != "" ] && [ "$JAVA_MAJOR" -ge "11" ]
+then
+  exec "$JAVA_BIN" \
+    --add-exports=java.base/jdk.internal.ref=ALL-UNNAMED \

Review Comment:
   Let's add all 4 options described in the "if you are running Java 11-13" section of datasketches-memory docs: https://github.com/apache/datasketches-memory#use-as-a-library-using-jars-from-maven-central
   
   ```
   --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
   --add-exports=java.base/jdk.internal.ref=ALL-UNNAMED
   --add-opens=java.base/java.nio=ALL-UNNAMED
   --add-opens=java.base/sun.nio.ch= ALL-UNNAMED
   ```
   
   And include a comment here that these parameters are for datasketches-memory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org