[GitHub] [dubbo] AlbumenJ commented on a change in pull request #9001: [3.0] check applicationModel destroy state at blockUntilUpdated

[GitBox <gi...@apache.org>]

AlbumenJ commented on a change in pull request #9001:
URL: https://github.com/apache/dubbo/pull/9001#discussion_r726711588



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
##########
@@ -791,13 +791,13 @@ public synchronized void destroy() {
             unRegisterShutdownHook();
             unregisterServiceInstance();
             unexportMetadataService();
-            if (asyncMetadataFuture != null) {
-                asyncMetadataFuture.cancel(true);
-            }
 
             executeShutdownCallbacks();
 
             applicationModel.destroy();
+            if (asyncMetadataFuture != null) {
+                asyncMetadataFuture.cancel(true);
+            }
 

Review comment:
       Metadata refresh future should be canceled after unregister service instance, which should be called before `applicationModel.destroy()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org