You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/02/07 01:48:56 UTC

Re: Review Request: Fix proxy scheduler/executor build warnings.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 12:48 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Changes
-------

Updated diff to address style issues and updated review to better reflect issue.


Summary (updated)
-----------------

Fix proxy scheduler/executor build warnings.


Description (updated)
-------

Python.h is a finicky header file. Include it before iostream.

Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files


This addresses bug MESOS-271.
    https://issues.apache.org/jira/browse/MESOS-271


Diffs (updated)
-----

  src/python/native/proxy_executor.cpp 2767e0a 
  src/python/native/proxy_scheduler.cpp 8bf368d 

Diff: https://reviews.apache.org/r/9320/diff/


Testing
-------

make check passes.


Thanks,

David Mackey

Re: Review Request: Fix proxy scheduler/executor build warnings.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/#review16229
-----------------------------------------------------------



src/python/native/proxy_executor.cpp
<https://reviews.apache.org/r/9320/#comment34684>

    periods at the end of sentences.



src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/9320/#comment34685>

    ditto


- Vinod Kone


On Feb. 7, 2013, 12:48 a.m., David Mackey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9320/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Python.h is a finicky header file. Include it before iostream.
> 
> Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files
> 
> 
> This addresses bug MESOS-271.
>     https://issues.apache.org/jira/browse/MESOS-271
> 
> 
> Diffs
> -----
> 
>   src/python/native/proxy_executor.cpp 2767e0a 
>   src/python/native/proxy_scheduler.cpp 8bf368d 
> 
> Diff: https://reviews.apache.org/r/9320/diff/
> 
> 
> Testing
> -------
> 
> make check passes.
> 
> 
> Thanks,
> 
> David Mackey
> 
>

Re: Review Request: Fix proxy scheduler/executor build warnings.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/#review16242
-----------------------------------------------------------



src/python/native/proxy_executor.cpp
<https://reviews.apache.org/r/9320/#comment34693>

    We've done this in other places as well, and IIRC this related to the redefinition of _POSIX_C_SOURCE?
    
    If so, can you update the comment to include a relevant link:
    // Must be included before standard headers.
    // See: http://docs.python.org/2/c-api/intro.html#include-files
    #include <Python.h>
    
    Also, can you update the other spots to include the comment:
      src/python/native/mesos_executor_driver_impl.cpp
      src/python/native/mesos_scheduler_driver_impl.cpp
      src/python/native/module.cpp
      src/python/native/module.hpp


- Ben Mahler


On Feb. 7, 2013, 1:06 a.m., David Mackey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9320/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 1:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Python.h is a finicky header file. Include it before iostream.
> 
> Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files
> 
> 
> This addresses bug MESOS-271.
>     https://issues.apache.org/jira/browse/MESOS-271
> 
> 
> Diffs
> -----
> 
>   src/python/native/proxy_executor.cpp 2767e0a 
>   src/python/native/proxy_scheduler.cpp 8bf368d 
> 
> Diff: https://reviews.apache.org/r/9320/diff/
> 
> 
> Testing
> -------
> 
> make check passes.
> 
> 
> Thanks,
> 
> David Mackey
> 
>

Re: Review Request: Fix Python header build warnings.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/#review16256
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Feb. 7, 2013, 2:15 a.m., David Mackey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9320/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 2:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Python.h is a finicky header file. Include it before iostream.
> 
> Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files
> 
> 
> This addresses bug MESOS-271.
>     https://issues.apache.org/jira/browse/MESOS-271
> 
> 
> Diffs
> -----
> 
>   src/python/native/mesos_executor_driver_impl.cpp f7930fb 
>   src/python/native/mesos_scheduler_driver_impl.cpp 00a08f9 
>   src/python/native/module.hpp c0ec442 
>   src/python/native/module.cpp 7e34356 
>   src/python/native/proxy_executor.hpp 1af3847 
>   src/python/native/proxy_executor.cpp 2767e0a 
>   src/python/native/proxy_scheduler.hpp fb492c7 
>   src/python/native/proxy_scheduler.cpp 8bf368d 
> 
> Diff: https://reviews.apache.org/r/9320/diff/
> 
> 
> Testing
> -------
> 
> make check passes.
> 
> 
> Thanks,
> 
> David Mackey
> 
>

Re: Review Request: Fix Python header build warnings.

Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 2:15 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Changes
-------

Add Python header comment to all relevant places.


Summary (updated)
-----------------

Fix Python header build warnings.


Description
-------

Python.h is a finicky header file. Include it before iostream.

Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files


This addresses bug MESOS-271.
    https://issues.apache.org/jira/browse/MESOS-271


Diffs (updated)
-----

  src/python/native/mesos_executor_driver_impl.cpp f7930fb 
  src/python/native/mesos_scheduler_driver_impl.cpp 00a08f9 
  src/python/native/module.hpp c0ec442 
  src/python/native/module.cpp 7e34356 
  src/python/native/proxy_executor.hpp 1af3847 
  src/python/native/proxy_executor.cpp 2767e0a 
  src/python/native/proxy_scheduler.hpp fb492c7 
  src/python/native/proxy_scheduler.cpp 8bf368d 

Diff: https://reviews.apache.org/r/9320/diff/


Testing
-------

make check passes.


Thanks,

David Mackey

Re: Review Request: Fix proxy scheduler/executor build warnings.

Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 1:06 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Changes
-------

Inline comment line length < 70? Either way, updated comment.


Description
-------

Python.h is a finicky header file. Include it before iostream.

Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files


This addresses bug MESOS-271.
    https://issues.apache.org/jira/browse/MESOS-271


Diffs (updated)
-----

  src/python/native/proxy_executor.cpp 2767e0a 
  src/python/native/proxy_scheduler.cpp 8bf368d 

Diff: https://reviews.apache.org/r/9320/diff/


Testing
-------

make check passes.


Thanks,

David Mackey

Re: Review Request: Fix proxy scheduler/executor build warnings.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/#review16230
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 7, 2013, 12:56 a.m., David Mackey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9320/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 12:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Python.h is a finicky header file. Include it before iostream.
> 
> Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files
> 
> 
> This addresses bug MESOS-271.
>     https://issues.apache.org/jira/browse/MESOS-271
> 
> 
> Diffs
> -----
> 
>   src/python/native/proxy_executor.cpp 2767e0a 
>   src/python/native/proxy_scheduler.cpp 8bf368d 
> 
> Diff: https://reviews.apache.org/r/9320/diff/
> 
> 
> Testing
> -------
> 
> make check passes.
> 
> 
> Thanks,
> 
> David Mackey
> 
>

Re: Review Request: Fix proxy scheduler/executor build warnings.

Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9320/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 12:56 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

Python.h is a finicky header file. Include it before iostream.

Relevant documentation: http://docs.python.org/2/c-api/intro.html#include-files


This addresses bug MESOS-271.
    https://issues.apache.org/jira/browse/MESOS-271


Diffs (updated)
-----

  src/python/native/proxy_executor.cpp 2767e0a 
  src/python/native/proxy_scheduler.cpp 8bf368d 

Diff: https://reviews.apache.org/r/9320/diff/


Testing
-------

make check passes.


Thanks,

David Mackey