[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1322: Replace list with other cache-friendly containers

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #1322:
URL: https://github.com/apache/incubator-kvrocks/pull/1322#discussion_r1138100234


##########
src/server/worker.cc:
##########
@@ -75,7 +75,9 @@ Worker::Worker(Server *svr, Config *config) : svr_(svr), base_(event_base_new())
 }
 
 Worker::~Worker() {
-  std::list<Redis::Connection *> conns;

Review Comment:
   This is a temporary local list, and we only use `emplace_back`. I think there is no reason we remove something from it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org