[GitHub] ctubbsii commented on a change in pull request #773: fixes #518 ignore non rfiles in new bulk import

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #773: fixes #518 ignore non rfiles in new bulk import
URL: https://github.com/apache/accumulo/pull/773#discussion_r234879118
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/functional/BulkLoadIT.java
 ##########
 @@ -231,6 +232,11 @@ private void testBulkFile(boolean offline, boolean usePlan) throws Exception {
         hashes.put(endRow, new HashSet<>());
       }
 
+      // Add a junk file, should be ignored
+      FSDataOutputStream out = fs.create(new Path(dir + "/junk"));
 
 Review comment:
   I think that the `Paths.get(dir, "junk")` syntax might be a bit cleaner than the concatenation. Not a bug, but probably better, in that it's less platform dependent on the OS path separator char, and therefore a good habit to get into.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services