You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Alexander Kriegisch (Jira)" <ji...@apache.org> on 2021/07/06 10:05:00 UTC
[jira] [Comment Edited] (MCHECKSTYLE-406) Make plugin compatible
with Checkstyle 8.44
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375425#comment-17375425 ]
Alexander Kriegisch edited comment on MCHECKSTYLE-406 at 7/6/21, 10:04 AM:
---------------------------------------------------------------------------
I know what the preconfigured version is, thanks. But OTOH, users are encouraged to upgrade the dependency right in the first paragraph of the [plugin homepage|https://maven.apache.org/plugins/maven-checkstyle-plugin/]:
{quote}This version of the plugin uses Checkstyle 8.29 by default and requires Java 8. But you can upgrade the version used at runtime.{quote}
There is a direct link to another page, describing [how to do that|https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html].
Like I said, it is not urgent, I simply wanted to create a ticket for you in order to make you aware of the fact that it does not work with the out-of-the-box configuration and that it might be a good idea to adjust that for the next release. If you think that the issue should be resolved in another component outside the scope of this plugin, that is fine with me. I have no way of knowing. I did not put checkstyle into the project, I found it there already. AFAIK, I am using the latest versions of everything in my POM, according to Dependabot, so I am not sure what I should upgrade.
As for the Mojohaus parent plugin config, those path names are not doing anything in AspectJ Maven, because the files simply do not exist. They are not mandatory.
I am not trying to complain about anything or pressurise you in any way. You might have noticed that I did not classify the issue as a bug but as a dependency upgrde. I am just a user trying to contribute a little bit of feedback to the maintainers who so generously provide me with this wonderful plugin, hoping that the feedback is useful and a future product version may benefit from it.
was (Author: kriegaex):
I know what the preconfigured version is, thanks. But OTOH, users are encouraged to upgrade the dependency right in the first paragraph of the [plugin homepage|https://maven.apache.org/plugins/maven-checkstyle-plugin/]:
{quote}This version of the plugin uses Checkstyle 8.29 by default and requires Java 8. But you can upgrade the version used at runtime.{quote}
There is a direct link to another page, describing [how to do that|https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html].
Like I said, it is not urgent, I simply wanted to create a ticket for you in order to make you aware of the fact that it does not work with the out-of-the-box configuration and that it might be a good idea to adjust that for the next release.
As for the Mojohaus parent plugin config, those path names are not doing anything in AspectJ Maven, because the files simply do not exist. They are not mandatory.
I am not trying to complain about anything or pressurise you in any way. You might have noticed that I did not classify the issue as a bug but as a dependency upgrde. I am just a user trying to contribute a little bit of feedback to the maintainers who so generously provide me with this wonderful plugin, hoping that the feedback is useful and a future product version may benefit from it.
> Make plugin compatible with Checkstyle 8.44
> -------------------------------------------
>
> Key: MCHECKSTYLE-406
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-406
> Project: Maven Checkstyle Plugin
> Issue Type: Dependency upgrade
> Affects Versions: 3.1.2
> Reporter: Alexander Kriegisch
> Priority: Major
>
> On GitHub, Dependabot suggests upgrading Checkstyle to something more recent than 8.41.1, but the corresponding builds fail, both for 8.43 and 8.44, e.g. [this build|https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20/checks?check_run_id=2933248023]:
> {code}
> Error: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on project aspectj-maven-plugin: Error generating maven-checkstyle-plugin:3.1.2:checkstyle report: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'scope' does not exist, please check the documentation -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on project aspectj-maven-plugin: Error generating maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
> (...)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:151)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
> (...)
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during checkstyle configuration
> at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure (AutomaticBean.java:201)
> at org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle (DefaultCheckstyleExecutor.java:167)
> at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport (AbstractCheckstyleReport.java:533)
> (...)
> {code}
> This is in no way urgent, but as Dependabot keeps bugging me with this for every new Checkstyle version, I thought I should mention it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)