You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2008/08/29 19:32:44 UTC
[jira] Created: (WICKET-1810) StringRequestTarget is bloated and
needs some care
StringRequestTarget is bloated and needs some care
--------------------------------------------------
Key: WICKET-1810
URL: https://issues.apache.org/jira/browse/WICKET-1810
Project: Wicket
Issue Type: Improvement
Components: wicket
Reporter: Peter Ertl
Attachments: StringRequestTarget.patch
when looking at StringRequestTarget I found the following things unnecessary
(1) create a Charset object where a String is sufficient for the encoding
(2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
(3) flush the output stream
(4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.
I made up an own version of StringRequestTarget and attached a patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1810) StringRequestTarget is bloated and
needs some care
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl closed WICKET-1810.
------------------------------
> StringRequestTarget is bloated and needs some care
> --------------------------------------------------
>
> Key: WICKET-1810
> URL: https://issues.apache.org/jira/browse/WICKET-1810
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Eelco Hillenius
> Fix For: 1.3.6, 1.4-M4
>
> Attachments: StringRequestTarget.patch
>
>
> when looking at StringRequestTarget I found the following things unnecessary
> (1) create a Charset object where a String is sufficient for the encoding
> (2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
> (3) flush the output stream
> (4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.
> I made up an own version of StringRequestTarget and attached a patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1810) StringRequestTarget is bloated and
needs some care
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-1810.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.4-M4
1.3.6
fixed in 1.3.x branch and trunk
> StringRequestTarget is bloated and needs some care
> --------------------------------------------------
>
> Key: WICKET-1810
> URL: https://issues.apache.org/jira/browse/WICKET-1810
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Eelco Hillenius
> Fix For: 1.3.6, 1.4-M4
>
> Attachments: StringRequestTarget.patch
>
>
> when looking at StringRequestTarget I found the following things unnecessary
> (1) create a Charset object where a String is sufficient for the encoding
> (2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
> (3) flush the output stream
> (4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.
> I made up an own version of StringRequestTarget and attached a patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1810) StringRequestTarget is bloated and
needs some care
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-1810:
-------------------------------
Attachment: StringRequestTarget.patch
> StringRequestTarget is bloated and needs some care
> --------------------------------------------------
>
> Key: WICKET-1810
> URL: https://issues.apache.org/jira/browse/WICKET-1810
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Peter Ertl
> Attachments: StringRequestTarget.patch
>
>
> when looking at StringRequestTarget I found the following things unnecessary
> (1) create a Charset object where a String is sufficient for the encoding
> (2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
> (3) flush the output stream
> (4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.
> I made up an own version of StringRequestTarget and attached a patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1810) StringRequestTarget is bloated and
needs some care
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1810:
-------------------------------------
Assignee: Eelco Hillenius
was there a specific reason you were buffering the string first?
> StringRequestTarget is bloated and needs some care
> --------------------------------------------------
>
> Key: WICKET-1810
> URL: https://issues.apache.org/jira/browse/WICKET-1810
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Eelco Hillenius
> Attachments: StringRequestTarget.patch
>
>
> when looking at StringRequestTarget I found the following things unnecessary
> (1) create a Charset object where a String is sufficient for the encoding
> (2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
> (3) flush the output stream
> (4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.
> I made up an own version of StringRequestTarget and attached a patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1810) StringRequestTarget is bloated and
needs some care
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1810:
----------------------------------
Fix Version/s: (was: 1.3.6)
1.3.5
> StringRequestTarget is bloated and needs some care
> --------------------------------------------------
>
> Key: WICKET-1810
> URL: https://issues.apache.org/jira/browse/WICKET-1810
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: StringRequestTarget.patch
>
>
> when looking at StringRequestTarget I found the following things unnecessary
> (1) create a Charset object where a String is sufficient for the encoding
> (2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
> (3) flush the output stream
> (4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.
> I made up an own version of StringRequestTarget and attached a patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.