You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2023/02/02 17:46:24 UTC
[GitHub] [cassandra] maedhroz opened a new pull request, #2132: use equals() rather than reference equality for excluding ourselves from the dependency builder
maedhroz opened a new pull request, #2132:
URL: https://github.com/apache/cassandra/pull/2132
patch by Benedict; reviewed by Caleb Rackliffe for CASSANDRA-18218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on a diff in pull request #2132: use equals() rather than reference equality for excluding ourselves from the dependency builder
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #2132:
URL: https://github.com/apache/cassandra/pull/2132#discussion_r1094870292
##########
.build/include-accord.sh:
##########
@@ -24,8 +24,8 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
-accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_branch='1230eceb077c928123e6bf848a103964fe90c9f7'
+accord_repo='https://github.com/maedhroz/cassandra-accord.git'
+accord_branch='349281bcb5a870312af2fe1c97601a1b494e22b7'
Review Comment:
Just for testing...this will revert back to a trunk commit when the accord side merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz merged pull request #2132: use equals() rather than reference equality for excluding ourselves from the dependency builder
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz merged PR #2132:
URL: https://github.com/apache/cassandra/pull/2132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on pull request #2132: use equals() rather than reference equality for excluding ourselves from the dependency builder
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2132:
URL: https://github.com/apache/cassandra/pull/2132#issuecomment-1414133213
https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-18218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org