You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/19 01:06:16 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #82: Only run exception thrown on existing bucket for Minio
mdedetrich opened a new pull request, #82:
URL: https://github.com/apache/incubator-pekko-connectors/pull/82
Comment in PR has explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #82: Only run exception thrown on existing bucket for Minio
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #82:
URL: https://github.com/apache/incubator-pekko-connectors/pull/82#issuecomment-1514377091
@He-Pin I have a slight improvement coming up, don't merge yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on pull request #82: Only run exception thrown on existing bucket for Minio
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #82:
URL: https://github.com/apache/incubator-pekko-connectors/pull/82#issuecomment-1514435350
Seems the connector part is not easy to testsπππ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #82: Only run exception thrown on existing bucket for Minio
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #82:
URL: https://github.com/apache/incubator-pekko-connectors/pull/82#issuecomment-1514386682
Okay I just improved the PR by also adding a test that confirms the S3 behaviour. Tested it against S3 account and I can confirm that it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #82: Only run exception thrown on existing bucket for Minio
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #82:
URL: https://github.com/apache/incubator-pekko-connectors/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #82: Only run exception thrown on existing bucket for Minio
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #82:
URL: https://github.com/apache/incubator-pekko-connectors/pull/82#issuecomment-1514443032
@He-Pin
You can read https://issues.apache.org/jira/browse/INFRA-24353?focusedCommentId=17713815&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17713815 for context but the current problem we are dealing with right now is that because these tests never ran against a real AWS account in CI a lot of tests have bit rotted (i.e. gradually broken) over time and I am now trying to fix them.
Even worse in some cases there are actual regressions and/or S3 changed their API behaviour, i.e. https://github.com/apache/incubator-pekko-connectors/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org