You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/29 07:08:45 UTC

[GitHub] [tvm] masahi edited a comment on pull request #7370: [Parser] Fix tokenizing inf

masahi edited a comment on pull request #7370:
URL: https://github.com/apache/tvm/pull/7370#issuecomment-769621909


   @jroesch To support `-inf`, I had to change `Tokenize()` loop, because I have to tokenize `-` and `inf` separately. I refactored the tokenizer a bit to clean up how to handle negation of both normal numbers and `inf`.
   
   Now, a digit parsing in `TokenizeOnce` does not handle negation and  `ParseNumber` always returns a positive number. The trailing negations are handled in `Tokenize()` loop. 
   
   This way, negation of positive numbers and `inf` are done in a unified way. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org