[GitHub] [geode] PurelyApplied commented on pull request #2643: GEODE-5846 GEODE-5850 GEODE-5860 GEODE-5862 GEODE-5878 fix JAVA_HOME

["PurelyApplied (GitHub)" <gi...@apache.org>]

I have mixed feelings about this and would like to hear other opinions...

On the one hand: I agree that restricting `JAVA_HOME` will provide a great deal of safety from accidentally leaking java versions where we don't mean to do so.

On the other hand: the `gradlew` wrapper is typically generated with the `gradle wrapper` command, and it feels off to deviate from that in a way that isn't in our `build.gradle`.

On the other other hand: `gradlew` is part of our source tree, so it's not as if we're encouraging developers to go fetch their own gradle wrapper in any event.

I think I'm still +1 on this PR overall, though.  Just a bit conflicted about it.

[ Full content available at: https://github.com/apache/geode/pull/2643 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org