[GitHub] [cassandra] maedhroz commented on a change in pull request #535: Cassandra 15229 trunk

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #535:
URL: https://github.com/apache/cassandra/pull/535#discussion_r497070645



##########
File path: src/java/org/apache/cassandra/utils/memory/BufferPool.java
##########
@@ -68,23 +112,40 @@
     public static final int TINY_ALLOCATION_UNIT = TINY_CHUNK_SIZE / 64;
     public static final int TINY_ALLOCATION_LIMIT = TINY_CHUNK_SIZE / 2;
 
-    private final static BufferPoolMetrics metrics = new BufferPoolMetrics();
-
-    // TODO: this should not be using FileCacheSizeInMB
-    private static long MEMORY_USAGE_THRESHOLD = DatabaseDescriptor.getFileCacheSizeInMB() * 1024L * 1024L;
-    private static String READABLE_MEMORY_USAGE_THRESHOLD = prettyPrintMemory(MEMORY_USAGE_THRESHOLD);
-
-    private static Debug debug;
-
     private static final Logger logger = LoggerFactory.getLogger(BufferPool.class);
     private static final NoSpamLogger noSpamLogger = NoSpamLogger.getLogger(logger, 15L, TimeUnit.MINUTES);
     private static final ByteBuffer EMPTY_BUFFER = ByteBuffer.allocateDirect(0);
 
+    private Debug debug;
+
+    protected final String name;
+    protected final BufferPoolMetrics metrics;
+    private long memoryUsageThreshold;
+    private String readableMemoryUsageThreshold; // FIXME
+
+    /**
+     * Size of unpooled buffer being allocated outside of buffer pool in bytes.
+     */
+    private final LongAdder overflowMemoryUsage = new LongAdder();
+
+    /**
+     * SIze of buffer being used in bytes, including pooled buffer and unpooled buffer.

Review comment:
       ```suggestion
        * Size of buffer being used in bytes, including pooled buffer and unpooled buffer.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org