You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by "poddm (via GitHub)" <gi...@apache.org> on 2026/04/30 16:55:34 UTC

Re: [PR] various fixes for fiberchannel and autoscale prefix option [cloudstack]

poddm commented on PR #11071:
URL: https://github.com/apache/cloudstack/pull/11071#issuecomment-4354450527

   @rg9975 - 
   
   Should MultipathSCSIAdapterBase.java or FiberChannelAdapter.java implement `AsyncPhysicalDiskConnectorDecorator`?
   
   this check in KVMStoragePoolManagerwould would never be true:
   
   ```java
   if (adaptor instanceof AsyncPhysicalDiskConnectorDecorator) {
   ```
   
   Java requires the interface to be declared on the class (or a superclass) for instanceof to match. Without it, the entire async disk connection path is dead code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org