[GitHub] [cordova-android] PieterVanPoyer commented on a change in pull request #1222: feat: add backwards compatibility mode for WebViewAssetLoader

[GitBox <gi...@apache.org>]

PieterVanPoyer commented on a change in pull request #1222:
URL: https://github.com/apache/cordova-android/pull/1222#discussion_r625066741



##########
File path: framework/src/org/apache/cordova/ConfigXmlParser.java
##########
@@ -46,9 +46,14 @@ public CordovaPreferences getPreferences() {
     }
 
     public String getLaunchUrl() {
-        if (launchUrl == null) { 
+        if (launchUrl == null) {

Review comment:
       Nice work!
   But, just a quick question.
   
   There is also a setStartUrl method. The launchUrl is also prefixed with https there.
   https://github.com/apache/cordova-android/pull/1222/files#diff-a32677abc0f97a96abd2948fad9d6b12f1251645a9f330431862dc83dabaeae2R150
   
   Should it be prefixed with file if the AndroidInsecureFileModeEnabled returns true?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org